# git rev-parse -q --verify 3a28c2c89f4b412b648761430720d40a8dc326ef^{commit} 3a28c2c89f4b412b648761430720d40a8dc326ef already have revision, skipping fetch # git checkout -q -f -B kisskb 3a28c2c89f4b412b648761430720d40a8dc326ef # git clean -qxdf # < git log -1 # commit 3a28c2c89f4b412b648761430720d40a8dc326ef # Merge: 74dc488b2a1b 0445d1bae1cc # Author: Linus Torvalds # Date: Mon Dec 12 08:12:27 2022 -0800 # # Merge tag 'unsigned-char-6.2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux # # Pull unsigned-char conversion from Jason Donenfeld: # "Enable -funsigned-char and fix code affected by that flag. # # During the 6.1 cycle, several patches already made it into the tree, # which were for code that was already broken on at least one # architecture, where the naked char had a different sign than the code # author anticipated, or were part of some bug fix for an existing bug # that this initiative unearthed. # # These 6.1-era fixes are: # # 648060902aa3 ("MIPS: pic32: treat port as signed integer") # 5c26159c97b3 ("ipvs: use explicitly signed chars") # e6cb8769452e ("wifi: airo: do not assign -1 to unsigned char") # 937ec9f7d5f2 ("staging: rtl8192e: remove bogus ssid character sign test") # 677047383296 ("misc: sgi-gru: use explicitly signed char") # 50895a55bcfd ("ALSA: rme9652: use explicitly signed char") # ee03c0f200eb ("ALSA: au88x0: use explicitly signed char") # 835bed1b8395 ("fbdev: sisfb: use explicitly signed char") # 50f19697dd76 ("parisc: Use signed char for hardware path in pdc.h") # 66063033f77e ("wifi: rt2x00: use explicitly signed or unsigned types") # # Regarding patches in this pull: # # - There is one patch in this pull that should have made it to you # during 6.1 ("media: stv0288: use explicitly signed char"), but the # maintainer was MIA during the cycle, so it's in here instead. # # - Two patches fix single architecture code affected by unsigned char # ("perf/x86: Make struct p4_event_bind::cntr signed array" and # "sparc: sbus: treat CPU index as integer"), while one patch fixes # an unused typedef, in case it's ever used in the future ("media: # atomisp: make hive_int8 explictly signed"). # # - Finally, there's the change to actually enable -funsigned-char # ("kbuild: treat char as always unsigned") and then the removal of # some no longer useful !__CHAR_UNSIGNED__ selftest code ("lib: # assume char is unsigned"). # # The various fixes were found with a combination of diffing objdump # output, a large variety of Coccinelle scripts, and plain old grep. In # the end, things didn't seem as bad as I feared they would. But of # course, it's also possible I missed things. # # However, this has been in linux-next for basically an entire cycle # now, so I'm not overly worried. I've also been daily driving this on # my laptop for all of 6.1. Still, this series, and the ones sent for # 6.1 don't total in quantity to what I thought it'd be, so I will be on # the lookout for breakage. # # We could receive a few reports that are quickly fixable. Hopefully we # won't receive a barrage of reports that would result in a revert. And # just maybe we won't receive any reports at all and nobody will even # notice. Knock on wood" # # * tag 'unsigned-char-6.2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux: # lib: assume char is unsigned # kbuild: treat char as always unsigned # media: atomisp: make hive_int8 explictly signed # media: stv0288: use explicitly signed char # sparc: sbus: treat CPU index as integer # perf/x86: Make struct p4_event_bind::cntr signed array # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 3a28c2c89f4b412b648761430720d40a8dc326ef # < make -s -j 32 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 allmodconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_KCOV=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n # Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n # Added to kconfig CONFIG_UML_NET=n # Added to kconfig CONFIG_UML_NET_ETHERTAP=n # Added to kconfig CONFIG_UML_NET_TUNTAP=n # Added to kconfig CONFIG_UML_NET_SLIP=n # Added to kconfig CONFIG_UML_NET_DAEMON=n # Added to kconfig CONFIG_UML_NET_VDE=n # Added to kconfig CONFIG_UML_NET_MCAST=n # Added to kconfig CONFIG_UML_NET_PCAP=n # Added to kconfig CONFIG_UML_NET_SLIRP=n # Added to kconfig CONFIG_GCOV_KERNEL=n # Added to kconfig CONFIG_DEBUG_INFO_BTF=n # Added to kconfig CONFIG_BPF_PRELOAD=n # < make -s -j 32 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 help # make -s -j 32 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 olddefconfig .config:12564:warning: override: reassigning to symbol GCC_PLUGIN_SANCOV .config:12569:warning: override: reassigning to symbol UML_NET_ETHERTAP .config:12571:warning: override: reassigning to symbol UML_NET_SLIP .config:12574:warning: override: reassigning to symbol UML_NET_MCAST .config:12576:warning: override: reassigning to symbol UML_NET_SLIRP # make -s -j 32 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 /kisskb/src/arch/um/os-Linux/util.c:17:24: fatal error: sys/random.h: No such file or directory compilation terminated. make[3]: *** [/kisskb/src/scripts/Makefile.build:250: arch/um/os-Linux/util.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:500: arch/um/os-Linux] Error 2 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/arch/x86/um/asm/processor.h:41:0, from /kisskb/src/include/linux/mutex.h:19, from /kisskb/src/include/linux/kernfs.h:11, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:35, from /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:26: /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function 'kfd_cpumask_to_apic_id': /kisskb/src/arch/um/include/asm/processor-generic.h:94:18: error: called object is not a function or function pointer #define cpu_data (&boot_cpu_data) ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1930:9: note: in expansion of macro 'cpu_data' return cpu_data(first_cpu_of_numa_node).apicid; ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:1934:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:250: drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/gpu/drm/amd/amdgpu] Error 2 make[5]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c: In function 'rvt_wss_llc_size': /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c:88:22: error: 'struct cpuinfo_um' has no member named 'x86_cache_size' return boot_cpu_data.x86_cache_size; ^ /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c: In function 'cacheless_memcpy': /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c:100:2: error: implicit declaration of function '__copy_user_nocache' [-Werror=implicit-function-declaration] __copy_user_nocache(dst, (void __user *)src, n, 0); ^ /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c: In function 'rvt_wss_llc_size': /kisskb/src/drivers/infiniband/sw/rdmavt/qp.c:89:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:250: drivers/infiniband/sw/rdmavt/qp.o] Error 1 make[5]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/infiniband/sw/rdmavt] Error 2 make[4]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/infiniband/sw] Error 2 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c: In function 'qib_unordered_wc': /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c:149:22: error: 'struct cpuinfo_um' has no member named 'x86_vendor' return boot_cpu_data.x86_vendor != X86_VENDOR_AMD; ^ /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c:149:37: error: 'X86_VENDOR_AMD' undeclared (first use in this function) return boot_cpu_data.x86_vendor != X86_VENDOR_AMD; ^ /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c:149:37: note: each undeclared identifier is reported only once for each function it appears in /kisskb/src/drivers/infiniband/hw/qib/qib_wc_x86_64.c:150:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:250: drivers/infiniband/hw/qib/qib_wc_x86_64.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/infiniband/hw/qib] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/infiniband/hw] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/infiniband] Error 2 make[3]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/gpu/drm] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/gpu] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:500: drivers] Error 2 make[1]: *** [/kisskb/src/Makefile:1992: .] Error 2 make: *** [Makefile:231: __sub-make] Error 2 Command 'make -s -j 32 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_um-allmodconfig_um-x86_64 # Build took: 0:11:28.345428