# git rev-parse -q --verify 3a28c2c89f4b412b648761430720d40a8dc326ef^{commit} 3a28c2c89f4b412b648761430720d40a8dc326ef already have revision, skipping fetch # git checkout -q -f -B kisskb 3a28c2c89f4b412b648761430720d40a8dc326ef # git clean -qxdf # < git log -1 # commit 3a28c2c89f4b412b648761430720d40a8dc326ef # Merge: 74dc488b2a1b 0445d1bae1cc # Author: Linus Torvalds # Date: Mon Dec 12 08:12:27 2022 -0800 # # Merge tag 'unsigned-char-6.2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux # # Pull unsigned-char conversion from Jason Donenfeld: # "Enable -funsigned-char and fix code affected by that flag. # # During the 6.1 cycle, several patches already made it into the tree, # which were for code that was already broken on at least one # architecture, where the naked char had a different sign than the code # author anticipated, or were part of some bug fix for an existing bug # that this initiative unearthed. # # These 6.1-era fixes are: # # 648060902aa3 ("MIPS: pic32: treat port as signed integer") # 5c26159c97b3 ("ipvs: use explicitly signed chars") # e6cb8769452e ("wifi: airo: do not assign -1 to unsigned char") # 937ec9f7d5f2 ("staging: rtl8192e: remove bogus ssid character sign test") # 677047383296 ("misc: sgi-gru: use explicitly signed char") # 50895a55bcfd ("ALSA: rme9652: use explicitly signed char") # ee03c0f200eb ("ALSA: au88x0: use explicitly signed char") # 835bed1b8395 ("fbdev: sisfb: use explicitly signed char") # 50f19697dd76 ("parisc: Use signed char for hardware path in pdc.h") # 66063033f77e ("wifi: rt2x00: use explicitly signed or unsigned types") # # Regarding patches in this pull: # # - There is one patch in this pull that should have made it to you # during 6.1 ("media: stv0288: use explicitly signed char"), but the # maintainer was MIA during the cycle, so it's in here instead. # # - Two patches fix single architecture code affected by unsigned char # ("perf/x86: Make struct p4_event_bind::cntr signed array" and # "sparc: sbus: treat CPU index as integer"), while one patch fixes # an unused typedef, in case it's ever used in the future ("media: # atomisp: make hive_int8 explictly signed"). # # - Finally, there's the change to actually enable -funsigned-char # ("kbuild: treat char as always unsigned") and then the removal of # some no longer useful !__CHAR_UNSIGNED__ selftest code ("lib: # assume char is unsigned"). # # The various fixes were found with a combination of diffing objdump # output, a large variety of Coccinelle scripts, and plain old grep. In # the end, things didn't seem as bad as I feared they would. But of # course, it's also possible I missed things. # # However, this has been in linux-next for basically an entire cycle # now, so I'm not overly worried. I've also been daily driving this on # my laptop for all of 6.1. Still, this series, and the ones sent for # 6.1 don't total in quantity to what I thought it'd be, so I will be on # the lookout for breakage. # # We could receive a few reports that are quickly fixable. Hopefully we # won't receive a barrage of reports that would result in a revert. And # just maybe we won't receive any reports at all and nobody will even # notice. Knock on wood" # # * tag 'unsigned-char-6.2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux: # lib: assume char is unsigned # kbuild: treat char as always unsigned # media: atomisp: make hive_int8 explictly signed # media: stv0288: use explicitly signed char # sparc: sbus: treat CPU index as integer # perf/x86: Make struct p4_event_bind::cntr signed array # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version # < git log --format=%s --max-count=1 3a28c2c89f4b412b648761430720d40a8dc326ef # < make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- help # make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- olddefconfig # make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S: Assembler messages: /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:85: Warning: overflow in branch to __restore_all; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:357: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:360: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence In file included from /kisskb/src/arch/sh/include/asm/hw_irq.h:6, from /kisskb/src/include/linux/irq.h:596, from /kisskb/src/include/asm-generic/hardirq.h:17, from /kisskb/src/arch/sh/include/asm/hardirq.h:9, from /kisskb/src/include/linux/hardirq.h:11, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/serial_core.h:13, from /kisskb/src/include/linux/serial_sci.h:6, from /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:11: /kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY' 105 | _INTC_ARRAY(vectors), _INTC_ARRAY(groups), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC' 58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:106:9: note: in expansion of macro '_INTC_ARRAY' 106 | _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC' 58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC' 58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC' 58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL, | ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:250: arch/sh/kernel/cpu/sh2/setup-sh7619.o] Error 1 make[5]: *** [/kisskb/src/scripts/Makefile.build:500: arch/sh/kernel/cpu/sh2] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:500: arch/sh/kernel/cpu] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:500: arch/sh/kernel] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:500: arch/sh] Error 2 make[2]: *** Waiting for unfinished jobs.... {standard input}: Assembler messages: {standard input}: Warning: end of file not at end of a line; newline inserted {standard input}:2305: Error: unknown pseudo-op: `.l' {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive {standard input}:2213: Error: displacement to undefined symbol .L382 overflows 8-bit field {standard input}:2286: Error: displacement to undefined symbol .L377 overflows 12-bit field {standard input}:2302: Error: displacement to undefined symbol .L378 overflows 8-bit field {standard input}:2204: Error: pcrel too far {standard input}:2206: Error: pcrel too far {standard input}:2209: Error: pcrel too far {standard input}:2215: Error: pcrel too far {standard input}:2216: Error: pcrel too far {standard input}:2217: Error: pcrel too far {standard input}:2221: Error: pcrel too far {standard input}:2229: Error: pcrel too far {standard input}:2231: Error: pcrel too far {standard input}:2232: Error: pcrel too far {standard input}:2247: Error: pcrel too far {standard input}:2248: Error: pcrel too far {standard input}:2249: Error: pcrel too far {standard input}:2259: Error: pcrel too far {standard input}:2261: Error: pcrel too far {standard input}:2262: Error: pcrel too far {standard input}:2274: Error: pcrel too far {standard input}:2293: Error: pcrel too far sh4-linux-gcc: internal compiler error: Segmentation fault signal terminated program cc1 Please submit a full bug report, with preprocessed source if appropriate. See for instructions. make[5]: *** [/kisskb/src/scripts/Makefile.build:250: drivers/net/pcs/pcs-xpcs.o] Error 4 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/net/pcs] Error 2 make[4]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/io.h:13, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/include/asm-generic/hardirq.h:17, from /kisskb/src/arch/sh/include/asm/hardirq.h:9, from /kisskb/src/include/linux/hardirq.h:11, from /kisskb/src/include/linux/highmem.h:12, from /kisskb/src/include/linux/bvec.h:10, from /kisskb/src/include/linux/skbuff.h:17, from /kisskb/src/include/net/net_namespace.h:43, from /kisskb/src/include/linux/netdevice.h:38, from /kisskb/src/drivers/staging/octeon/ethernet-mem.c:9: /kisskb/src/drivers/staging/octeon/ethernet-mem.c: In function 'cvm_oct_free_hw_memory': /kisskb/src/arch/sh/include/asm/io.h:239:34: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 239 | #define phys_to_virt(address) ((void *)(address)) | ^ /kisskb/src/drivers/staging/octeon/ethernet-mem.c:123:39: note: in expansion of macro 'phys_to_virt' 123 | fpa = (char *)phys_to_virt(cvmx_ptr_to_phys(fpa)); | ^~~~~~~~~~~~ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:250: drivers/staging/octeon/ethernet-mem.o] Error 1 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/staging/octeon] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/staging] Error 2 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:500: drivers/net] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:500: drivers] Error 2 make[1]: *** [/kisskb/src/Makefile:1992: .] Error 2 make: *** [Makefile:231: __sub-make] Error 2 Command 'make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_sh-allmodconfig_sh4-gcc11 # Build took: 0:06:03.126100