# git rev-parse -q --verify 3a28c2c89f4b412b648761430720d40a8dc326ef^{commit} 3a28c2c89f4b412b648761430720d40a8dc326ef already have revision, skipping fetch # git checkout -q -f -B kisskb 3a28c2c89f4b412b648761430720d40a8dc326ef # git clean -qxdf # < git log -1 # commit 3a28c2c89f4b412b648761430720d40a8dc326ef # Merge: 74dc488b2a1b 0445d1bae1cc # Author: Linus Torvalds # Date: Mon Dec 12 08:12:27 2022 -0800 # # Merge tag 'unsigned-char-6.2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux # # Pull unsigned-char conversion from Jason Donenfeld: # "Enable -funsigned-char and fix code affected by that flag. # # During the 6.1 cycle, several patches already made it into the tree, # which were for code that was already broken on at least one # architecture, where the naked char had a different sign than the code # author anticipated, or were part of some bug fix for an existing bug # that this initiative unearthed. # # These 6.1-era fixes are: # # 648060902aa3 ("MIPS: pic32: treat port as signed integer") # 5c26159c97b3 ("ipvs: use explicitly signed chars") # e6cb8769452e ("wifi: airo: do not assign -1 to unsigned char") # 937ec9f7d5f2 ("staging: rtl8192e: remove bogus ssid character sign test") # 677047383296 ("misc: sgi-gru: use explicitly signed char") # 50895a55bcfd ("ALSA: rme9652: use explicitly signed char") # ee03c0f200eb ("ALSA: au88x0: use explicitly signed char") # 835bed1b8395 ("fbdev: sisfb: use explicitly signed char") # 50f19697dd76 ("parisc: Use signed char for hardware path in pdc.h") # 66063033f77e ("wifi: rt2x00: use explicitly signed or unsigned types") # # Regarding patches in this pull: # # - There is one patch in this pull that should have made it to you # during 6.1 ("media: stv0288: use explicitly signed char"), but the # maintainer was MIA during the cycle, so it's in here instead. # # - Two patches fix single architecture code affected by unsigned char # ("perf/x86: Make struct p4_event_bind::cntr signed array" and # "sparc: sbus: treat CPU index as integer"), while one patch fixes # an unused typedef, in case it's ever used in the future ("media: # atomisp: make hive_int8 explictly signed"). # # - Finally, there's the change to actually enable -funsigned-char # ("kbuild: treat char as always unsigned") and then the removal of # some no longer useful !__CHAR_UNSIGNED__ selftest code ("lib: # assume char is unsigned"). # # The various fixes were found with a combination of diffing objdump # output, a large variety of Coccinelle scripts, and plain old grep. In # the end, things didn't seem as bad as I feared they would. But of # course, it's also possible I missed things. # # However, this has been in linux-next for basically an entire cycle # now, so I'm not overly worried. I've also been daily driving this on # my laptop for all of 6.1. Still, this series, and the ones sent for # 6.1 don't total in quantity to what I thought it'd be, so I will be on # the lookout for breakage. # # We could receive a few reports that are quickly fixable. Hopefully we # won't receive a barrage of reports that would result in a revert. And # just maybe we won't receive any reports at all and nobody will even # notice. Knock on wood" # # * tag 'unsigned-char-6.2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux: # lib: assume char is unsigned # kbuild: treat char as always unsigned # media: atomisp: make hive_int8 explictly signed # media: stv0288: use explicitly signed char # sparc: sbus: treat CPU index as integer # perf/x86: Make struct p4_event_bind::cntr signed array # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version # < git log --format=%s --max-count=1 3a28c2c89f4b412b648761430720d40a8dc326ef # < make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-defconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- defconfig # < make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-defconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- help # make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-defconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- olddefconfig # make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-defconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.1.0-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1517:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/arch/sh/include/asm/hw_irq.h:6, from /kisskb/src/include/linux/irq.h:596, from /kisskb/src/include/asm-generic/hardirq.h:17, from /kisskb/src/arch/sh/include/asm/hardirq.h:9, from /kisskb/src/include/linux/hardirq.h:11, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/serial_core.h:13, from /kisskb/src/include/linux/serial_sci.h:6, from /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:10: /kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:309:8: note: in expansion of macro 'DECLARE_INTC_DESC' 309 | static DECLARE_INTC_DESC(intc_desc, "shx3", vectors, groups, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:309:8: note: in expansion of macro 'DECLARE_INTC_DESC' 309 | static DECLARE_INTC_DESC(intc_desc, "shx3", vectors, groups, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:322:8: note: in expansion of macro 'DECLARE_INTC_DESC' 322 | static DECLARE_INTC_DESC(intc_desc_irq, "shx3-irq", vectors_irq, groups, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:337:8: note: in expansion of macro 'DECLARE_INTC_DESC' 337 | static DECLARE_INTC_DESC(intc_desc_irl, "shx3-irl", vectors_irl, groups, | ^~~~~~~~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:100:63: warning: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Wsizeof-pointer-div] 100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a) | ^ /kisskb/src/include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY' 107 | _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \ | ^~~~~~~~~~~ /kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC' 124 | .hw = INTC_HW_DESC(vectors, groups, mask_regs, \ | ^~~~~~~~~~~~ /kisskb/src/arch/sh/kernel/cpu/sh4a/setup-shx3.c:337:8: note: in expansion of macro 'DECLARE_INTC_DESC' 337 | static DECLARE_INTC_DESC(intc_desc_irl, "shx3-irl", vectors_irl, groups, | ^~~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/readpage.c: In function 'ext4_mpage_readpages': /kisskb/src/fs/ext4/readpage.c:409:1: warning: the frame size of 1132 bytes is larger than 1024 bytes [-Wframe-larger-than=] 409 | } | ^ /kisskb/src/fs/mpage.c: In function '__mpage_writepage': /kisskb/src/fs/mpage.c:634:1: warning: the frame size of 1144 bytes is larger than 1024 bytes [-Wframe-larger-than=] 634 | } | ^ /kisskb/src/fs/mpage.c: In function 'do_mpage_readpage': /kisskb/src/fs/mpage.c:308:1: warning: the frame size of 1092 bytes is larger than 1024 bytes [-Wframe-larger-than=] 308 | } | ^ Kernel: arch/sh/boot/zImage is ready Completed OK # rm -rf /kisskb/build/linus_sh-defconfig_sh4-gcc11 # Build took: 0:01:31.981374