# git rev-parse -q --verify be5f95c8779e19779dd81927c8574fec5aaba36c^{commit} be5f95c8779e19779dd81927c8574fec5aaba36c already have revision, skipping fetch # git checkout -q -f -B kisskb be5f95c8779e19779dd81927c8574fec5aaba36c # git clean -qxdf # < git log -1 # commit be5f95c8779e19779dd81927c8574fec5aaba36c # Author: Michael Ellerman # Date: Thu Jan 5 22:42:59 2023 +1100 # # powerpc/vmlinux.lds: Don't discard .comment # # Although the powerpc linker script mentions .comment in the DISCARD # section, that has never actually caused it to be discarded, because the # earlier ELF_DETAILS macro (previously STABS_DEBUG) explicitly includes # .comment. # # However commit 99cb0d917ffa ("arch: fix broken BuildID for arm64 and # riscv") introduced an earlier use of DISCARD as part of the RO_DATA # macro. With binutils < 2.36 that causes the DISCARD directives later in # the script to be applied earlier, causing .comment to actually be # discarded. # # It's confusing to explicitly include and discard .comment, and even more # so if the behaviour depends on the toolchain version. So don't discard # .comment in order to maintain the existing behaviour in all cases. # # Fixes: 83a092cf95f2 ("powerpc: Link warning for orphan sections") # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20230105132349.384666-3-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 be5f95c8779e19779dd81927c8574fec5aaba36c # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_makalu_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- 40x/makalu_defconfig # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_makalu_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_makalu_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_40x_makalu_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/powerpc-fixes_40x_makalu_defconfig_powerpc-gcc5 # Build took: 0:00:35.109526