# git rev-parse -q --verify fc546faa559538fb312c77e055243ece18ab3288^{commit} fc546faa559538fb312c77e055243ece18ab3288 already have revision, skipping fetch # git checkout -q -f -B kisskb fc546faa559538fb312c77e055243ece18ab3288 # git clean -qxdf # < git log -1 # commit fc546faa559538fb312c77e055243ece18ab3288 # Author: Sourabh Jain # Date: Tue Jan 31 08:36:15 2023 +0530 # # powerpc/kexec_file: Count hot-pluggable memory in FDT estimate # # On Systems where online memory is lesser compared to max memory, the # kexec_file_load system call may fail to load the kdump kernel with the # below errors: # # "Failed to update fdt with linux,drconf-usable-memory property" # "Error setting up usable-memory property for kdump kernel" # # This happens because the size estimation for usable memory properties # for the kdump kernel's FDT is based on the online memory whereas the # usable memory properties include max memory. In short, the hot-pluggable # memory is not accounted for while estimating the size of the usable # memory properties. # # The issue is addressed by calculating usable memory property size using # max hotplug address instead of the last online memory address. # # Fixes: 2377c92e37fe ("powerpc/kexec_file: fix FDT size estimation for kdump kernel") # Signed-off-by: Sourabh Jain # Signed-off-by: Michael Ellerman # Link: https://lore.kernel.org/r/20230131030615.729894-1-sourabhjain@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 fc546faa559538fb312c77e055243ece18ab3288 # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- powernv_defconfig # Added to kconfig CONFIG_NUMA=n # < make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/kexec/file_load_64.c: In function 'kexec_extra_fdt_size_ppc64': /kisskb/src/arch/powerpc/kexec/file_load_64.c:993:33: error: implicit declaration of function 'memory_hotplug_max' [-Werror=implicit-function-declaration] 993 | usm_entries = ((memory_hotplug_max() / drmem_lmb_size()) + | ^~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:252: arch/powerpc/kexec/file_load_64.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:504: arch/powerpc/kexec] Error 2 make[3]: *** Waiting for unfinished jobs.... arch/powerpc/kernel/head_64.o: warning: objtool: end_first_256B(): can't find starting instruction arch/powerpc/kernel/optprobes_head.o: warning: objtool: optprobe_template_end(): can't find starting instruction make[2]: *** [/kisskb/src/scripts/Makefile.build:504: arch/powerpc] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:2008: .] Error 2 make: *** [Makefile:242: __sub-make] Error 2 Command 'make -s -j 32 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-fixes_powernv_defconfig+NO_NUMA_powerpc-gcc12 # Build took: 0:02:55.608034