Buildresult: linus/xtensa-allnoconfig/xtensa-gcc11 built on Feb 28 2023, 15:27

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Feb 28 2023, 15:27
Duration:	0:00:22.921008
Builder:	ka7
Revision:	vfs: avoid duplicating creds in faccessat if possible (`981ee95cc1f5905ae4936b0dd501085909cdc14f)`
Target:	linus/xtensa-allnoconfig/xtensa-gcc11
Branch:	linus
Compiler:	xtensa-gcc11 (xtensa-linux-gcc (GCC) 11.3.0 / GNU ld (GNU Binutils) 2.38)
Config:	allnoconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 981ee95cc1f5905ae4936b0dd501085909cdc14f^{commit} 981ee95cc1f5905ae4936b0dd501085909cdc14f already have revision, skipping fetch # git checkout -q -f -B kisskb 981ee95cc1f5905ae4936b0dd501085909cdc14f # git clean -qxdf # < git log -1 # commit 981ee95cc1f5905ae4936b0dd501085909cdc14f # Author: Mateusz Guzik <mjguzik@gmail.com> # Date: Wed Jan 25 16:55:57 2023 +0100 # # vfs: avoid duplicating creds in faccessat if possible # # access(2) remains commonly used, for example on exec: # access("/etc/ld.so.preload", R_OK) # # or when running gcc: strace -c gcc empty.c # # % time seconds usecs/call calls errors syscall # ------ ----------- ----------- --------- --------- ---------------- # 0.00 0.000000 0 42 26 access # # It falls down to do_faccessat without the AT_EACCESS flag, which in turn # results in allocation of new creds in order to modify fsuid/fsgid and # caps. This is a very expensive process single-threaded and most notably # multi-threaded, with numerous structures getting refed and unrefed on # imminent new cred destruction. # # Turns out for typical consumers the resulting creds would be identical # and this can be checked upfront, avoiding the hard work. # # An access benchmark plugged into will-it-scale running on Cascade Lake # shows: # # test proc before after # access1 1 1310582 2908735 (+121%) # distinct files # access1 24 4716491 63822173 (+1353%) # distinct files # access2 24 2378041 5370335 (+125%) # same file # # The above benchmarks are not integrated into will-it-scale, but can be # found in a pull request: # # https://github.com/antonblanchard/will-it-scale/pull/36/files # # Signed-off-by: Mateusz Guzik <mjguzik@gmail.com> # Cc: Al Viro <viro@zeniv.linux.org.uk> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/xtensa-linux/bin/xtensa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/xtensa-linux/bin/xtensa-linux-ld --version # < git log --format=%s --max-count=1 981ee95cc1f5905ae4936b0dd501085909cdc14f # < make -s -j 32 ARCH=xtensa O=/kisskb/build/linus_xtensa-allnoconfig_xtensa-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/xtensa-linux/bin/xtensa-linux- allnoconfig # < make -s -j 32 ARCH=xtensa O=/kisskb/build/linus_xtensa-allnoconfig_xtensa-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/xtensa-linux/bin/xtensa-linux- help # make -s -j 32 ARCH=xtensa O=/kisskb/build/linus_xtensa-allnoconfig_xtensa-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/xtensa-linux/bin/xtensa-linux- olddefconfig # make -s -j 32 ARCH=xtensa O=/kisskb/build/linus_xtensa-allnoconfig_xtensa-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/xtensa-linux/bin/xtensa-linux- Completed OK # rm -rf /kisskb/build/linus_xtensa-allnoconfig_xtensa-gcc11 # Build took: 0:00:22.921008

© Michael Ellerman 2006-2018.