# git rev-parse -q --verify ae3419fbac845b4d3f3a9fae4cc80c68d82cdf6e^{commit}
ae3419fbac845b4d3f3a9fae4cc80c68d82cdf6e
already have revision, skipping fetch
# git checkout -q -f -B kisskb ae3419fbac845b4d3f3a9fae4cc80c68d82cdf6e
# git clean -qxdf
# < git log -1
# commit ae3419fbac845b4d3f3a9fae4cc80c68d82cdf6e
# Author: Thomas Weißschuh <linux@weissschuh.net>
# Date:   Mon Feb 20 06:46:12 2023 +0000
# 
#     vc_screen: don't clobber return value in vcs_read
#     
#     Commit 226fae124b2d ("vc_screen: move load of struct vc_data pointer in
#     vcs_read() to avoid UAF") moved the call to vcs_vc() into the loop.
#     
#     While doing this it also moved the unconditional assignment of
#     
#             ret = -ENXIO;
#     
#     This unconditional assignment was valid outside the loop but within it
#     it clobbers the actual value of ret.
#     
#     To avoid this only assign "ret = -ENXIO" when actually needed.
#     
#     [ Also, the 'goto unlock_out" needs to be just a "break", so that it
#       does the right thing when it exits on later iterations when partial
#       success has happened - Linus ]
#     
#     Reported-by: Storm Dragon <stormdragon2976@gmail.com>
#     Link: https://lore.kernel.org/lkml/Y%2FKS6vdql2pIsCiI@hotmail.com/
#     Fixes: 226fae124b2d ("vc_screen: move load of struct vc_data pointer in vcs_read() to avoid UAF")
#     Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
#     Link: https://lore.kernel.org/lkml/64981d94-d00c-4b31-9063-43ad0a384bde@t-8ch.de/
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 ae3419fbac845b4d3f3a9fae4cc80c68d82cdf6e
# < make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  allyesconfig
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_MODULE_SIG=n
# < make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  help
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  olddefconfig
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S: Assembler messages:
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:85: Warning: overflow in branch to __restore_all; converted into longer instruction sequence
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:357: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:360: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
In file included from /kisskb/src/arch/sh/include/asm/hw_irq.h:6,
                 from /kisskb/src/include/linux/irq.h:596,
                 from /kisskb/src/include/asm-generic/hardirq.h:17,
                 from /kisskb/src/arch/sh/include/asm/hardirq.h:9,
                 from /kisskb/src/include/linux/hardirq.h:11,
                 from /kisskb/src/include/linux/interrupt.h:11,
                 from /kisskb/src/include/linux/serial_core.h:13,
                 from /kisskb/src/include/linux/serial_sci.h:6,
                 from /kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:11:
/kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:105:31: note: in expansion of macro '_INTC_ARRAY'
  105 |         _INTC_ARRAY(vectors), _INTC_ARRAY(groups),      \
      |                               ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC'
  124 |         .hw = INTC_HW_DESC(vectors, groups, mask_regs,                  \
      |               ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:106:9: note: in expansion of macro '_INTC_ARRAY'
  106 |         _INTC_ARRAY(mask_regs), _INTC_ARRAY(prio_regs), \
      |         ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC'
  124 |         .hw = INTC_HW_DESC(vectors, groups, mask_regs,                  \
      |               ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:9: note: in expansion of macro '_INTC_ARRAY'
  107 |         _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |         ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC'
  124 |         .hw = INTC_HW_DESC(vectors, groups, mask_regs,                  \
      |               ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:100:63: error: division 'sizeof (void *) / sizeof (void)' does not compute the number of array elements [-Werror=sizeof-pointer-div]
  100 | #define _INTC_ARRAY(a) a, __same_type(a, NULL) ? 0 : sizeof(a)/sizeof(*a)
      |                                                               ^
/kisskb/src/include/linux/sh_intc.h:107:34: note: in expansion of macro '_INTC_ARRAY'
  107 |         _INTC_ARRAY(sense_regs), _INTC_ARRAY(ack_regs), \
      |                                  ^~~~~~~~~~~
/kisskb/src/include/linux/sh_intc.h:124:15: note: in expansion of macro 'INTC_HW_DESC'
  124 |         .hw = INTC_HW_DESC(vectors, groups, mask_regs,                  \
      |               ^~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh2/setup-sh7619.c:58:8: note: in expansion of macro 'DECLARE_INTC_DESC'
   58 | static DECLARE_INTC_DESC(intc_desc, "sh7619", vectors, NULL,
      |        ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [/kisskb/src/scripts/Makefile.build:252: arch/sh/kernel/cpu/sh2/setup-sh7619.o] Error 1
make[6]: *** Waiting for unfinished jobs....
make[5]: *** [/kisskb/src/scripts/Makefile.build:494: arch/sh/kernel/cpu/sh2] Error 2
make[4]: *** [/kisskb/src/scripts/Makefile.build:494: arch/sh/kernel/cpu] Error 2
make[3]: *** [/kisskb/src/scripts/Makefile.build:494: arch/sh/kernel] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/kisskb/src/scripts/Makefile.build:494: arch/sh] Error 2
make[2]: *** Waiting for unfinished jobs....
{standard input}: Assembler messages:
{standard input}: Warning: end of file not at end of a line; newline inserted
{standard input}:1118: Error: unknown pseudo-op: `.'
sh4-linux-gcc: internal compiler error: Segmentation fault signal terminated program cc1
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
make[5]: *** [/kisskb/src/scripts/Makefile.build:252: drivers/net/pcs/pcs-xpcs.o] Error 4
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/net/pcs] Error 2
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/net] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/kisskb/src/scripts/Makefile.build:494: drivers] Error 2
make[1]: *** [/kisskb/src/Makefile:2028: .] Error 2
make: *** [Makefile:226: __sub-make] Error 2
Command 'make -s -j 160 ARCH=sh O=/kisskb/build/linus_sh-allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  ' returned non-zero exit status 2
# rm -rf /kisskb/build/linus_sh-allyesconfig_sh4-gcc11
# Build took: 0:03:34.271397