# git rev-parse -q --verify 7b50567bdcad8925ca1e075feb7171c12015afd1^{commit} 7b50567bdcad8925ca1e075feb7171c12015afd1 already have revision, skipping fetch # git checkout -q -f -B kisskb 7b50567bdcad8925ca1e075feb7171c12015afd1 # git clean -qxdf # < git log -1 # commit 7b50567bdcad8925ca1e075feb7171c12015afd1 # Author: Arnd Bergmann # Date: Tue Feb 7 17:13:12 2023 +0100 # # media: i2c: imx290: fix conditional function defintions # # The runtime suspend/resume functions are only referenced from the # dev_pm_ops, but they use the old SET_RUNTIME_PM_OPS() helper that # requires a __maybe_unused annotation to avoid a warning: # # drivers/media/i2c/imx290.c:1082:12: error: unused function 'imx290_runtime_resume' [-Werror,-Wunused-function] # static int imx290_runtime_resume(struct device *dev) # ^ # drivers/media/i2c/imx290.c:1090:12: error: unused function 'imx290_runtime_suspend' [-Werror,-Wunused-function] # static int imx290_runtime_suspend(struct device *dev) # ^ # # Convert this to the new RUNTIME_PM_OPS() helper that so this is not # required. To improve this further, also use the pm_ptr() helper that # lets the dev_pm_ops get dropped entirely when CONFIG_PM is disabled. # # A related mistake happened in the of_match_ptr() macro here, which like # SET_RUNTIME_PM_OPS() requires the match table to be marked as # __maybe_unused, though I could not reproduce building this without # CONFIG_OF. Remove the of_match_ptr() here as there is no point in # dropping the match table in configurations without CONFIG_OF. # # Fixes: 02852c01f654 ("media: i2c: imx290: Initialize runtime PM before subdev") # Signed-off-by: Arnd Bergmann # Reported-by: Guenter Roeck # Reported-by: Sudip Mukherjee # Reviewed-by: Manivannan Sadhasivam # Reviewed-by: Laurent Pinchart # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 7b50567bdcad8925ca1e075feb7171c12015afd1 # < make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- sun3_defconfig # < make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 32 ARCH=m68k O=/kisskb/build/linus_sun3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- In file included from /kisskb/src/include/linux/swab.h:5, from /kisskb/src/include/uapi/linux/byteorder/big_endian.h:14, from /kisskb/src/include/linux/byteorder/big_endian.h:5, from /kisskb/src/arch/m68k/include/uapi/asm/byteorder.h:5, from /kisskb/src/include/asm-generic/bitops/le.h:6, from /kisskb/src/arch/m68k/include/asm/bitops.h:545, from /kisskb/src/include/linux/bitops.h:68, from /kisskb/src/include/linux/kernel.h:22, from /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:31: /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:989:108: warning: array subscript 1 is above array bounds of 'volatile struct transmit_cmd_struct *[1]' [-Warray-bounds] printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); ~~~~~~~~~~~~^~~ /kisskb/src/include/uapi/linux/swab.h:107:12: note: in definition of macro '__swab16' __fswab16(x)) ^ /kisskb/src/include/linux/printk.h:455:26: note: in expansion of macro 'printk_index_wrap' #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__) ^~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/i825xx/sun3_82586.c:989:3: note: in expansion of macro 'printk' printk("%s: command-stats: %04x %04x\n",dev->name,swab16(p->xmit_cmds[0]->cmd_status),swab16(p->xmit_cmds[1]->cmd_status)); ^~~~~~ In file included from /kisskb/src/include/linux/rculist.h:10, from /kisskb/src/include/linux/pid.h:5, from /kisskb/src/include/linux/sched.h:14, from /kisskb/src/fs/btrfs/volumes.c:6: /kisskb/src/fs/btrfs/volumes.c: In function 'btrfs_init_new_device': /kisskb/src/include/linux/list.h:74:12: warning: 'seed_devices' may be used uninitialized in this function [-Wmaybe-uninitialized] new->prev = prev; ~~~~~~~~~~^~~~~~ /kisskb/src/fs/btrfs/volumes.c:2612:27: note: 'seed_devices' was declared here struct btrfs_fs_devices *seed_devices; ^~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_sun3_defconfig_m68k-gcc8 # Build took: 0:01:31.570080