# git rev-parse -q --verify 358e526a1648cdd773ba169da5867874ae2408e3^{commit} 358e526a1648cdd773ba169da5867874ae2408e3 already have revision, skipping fetch # git checkout -q -f -B kisskb 358e526a1648cdd773ba169da5867874ae2408e3 # git clean -qxdf # < git log -1 # commit 358e526a1648cdd773ba169da5867874ae2408e3 # Author: Michael Ellerman # Date: Fri May 19 21:38:06 2023 +1000 # # powerpc/mm: Reinstate ARCH_FORCE_MAX_ORDER ranges # # Commit 1e8fed873e74 ("powerpc: drop ranges for definition of # ARCH_FORCE_MAX_ORDER") removed the limits on the possible values for # ARCH_FORCE_MAX_ORDER. # # However removing the ranges entirely causes some common work flows to # break. For example building a defconfig (which uses 64K pages), changing # the page size to 4K, and rebuilding used to work, because # ARCH_FORCE_MAX_ORDER would be clamped to 12 by the ranges. # # With the ranges removed it creates a kernel that builds but crashes at # boot: # kernel BUG at mm/huge_memory.c:470! # Oops: Exception in kernel mode, sig: 5 [#1] # ... # NIP hugepage_init+0x9c/0x278 # LR do_one_initcall+0x80/0x320 # Call Trace: # do_one_initcall+0x80/0x320 # kernel_init_freeable+0x304/0x3ac # kernel_init+0x30/0x1a0 # ret_from_kernel_user_thread+0x14/0x1c # # The reasoning for removing the ranges was that some of the values were # too large. So take that into account and limit the maximums to 10 which # is the default max, except for the 4K case which uses 12. # # Fixes: 1e8fed873e74 ("powerpc: drop ranges for definition of ARCH_FORCE_MAX_ORDER") # Signed-off-by: Michael Ellerman # Link: https://msgid.link/20230519113806.370635-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 358e526a1648cdd773ba169da5867874ae2408e3 # < make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # Added to kconfig CONFIG_PPC_E500MC=y # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM_E500MC=y # Added to kconfig # < make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:4495:warning: override: reassigning to symbol PPC_E500MC .config:4496:warning: override: reassigning to symbol VIRTUALIZATION # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/build_bug.h:5, from /kisskb/src/include/linux/container_of.h:5, from /kisskb/src/include/linux/list.h:5, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 22 | #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) | ^ /kisskb/src/include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:13: note: in expansion of macro 'IS_ERR_VALUE' 139 | if (IS_ERR_VALUE(fep->ring_mem_addr)) | ^~~~~~~~~~~~ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:341.15-350.5: Warning (pci_device_reg): /pci@e0008000/i8259@19000: PCI unit address format error, expected "12,0" /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:330.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_defconfig+KVM_powerpc-gcc12 # Build took: 0:03:06.449986