# git rev-parse -q --verify c0a572d9d32fe1e95672f24e860776dba0750a38^{commit} c0a572d9d32fe1e95672f24e860776dba0750a38 already have revision, skipping fetch # git checkout -q -f -B kisskb c0a572d9d32fe1e95672f24e860776dba0750a38 # git clean -qxdf # < git log -1 # commit c0a572d9d32fe1e95672f24e860776dba0750a38 # Merge: 1f2300a73821 6ac392815628 # Author: Linus Torvalds # Date: Mon Jun 26 10:27:04 2023 -0700 # # Merge tag 'v6.5/vfs.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs # # Pull vfs mount updates from Christian Brauner: # "This contains the work to extend move_mount() to allow adding a mount # beneath the topmost mount of a mount stack. # # There are two LWN articles about this. One covers the original patch # series in [1]. The other in [2] summarizes the session and roughly the # discussion between Al and me at LSFMM. The second article also goes # into some good questions from attendees. # # Since all details are found in the relevant commit with a technical # dive into semantics and locking at the end I'm only adding the # motivation and core functionality for this from commit message and # leave out the invasive details. The code is also heavily commented and # annotated as well which was explicitly requested. # # TL;DR: # # > mount -t ext4 /dev/sda /mnt # | # └─/mnt /dev/sda ext4 # # > mount --beneath -t xfs /dev/sdb /mnt # | # └─/mnt /dev/sdb xfs # └─/mnt /dev/sda ext4 # # > umount /mnt # | # └─/mnt /dev/sdb xfs # # The longer motivation is that various distributions are adding or are # in the process of adding support for system extensions and in the # future configuration extensions through various tools. A more detailed # explanation on system and configuration extensions can be found on the # manpage which is listed below at [3]. # # System extension images may – dynamically at runtime — extend the # /usr/ and /opt/ directory hierarchies with additional files. This is # particularly useful on immutable system images where a /usr/ and/or # /opt/ hierarchy residing on a read-only file system shall be extended # temporarily at runtime without making any persistent modifications. # # When one or more system extension images are activated, their /usr/ # and /opt/ hierarchies are combined via overlayfs with the same # hierarchies of the host OS, and the host /usr/ and /opt/ overmounted # with it ("merging"). When they are deactivated, the mount point is # disassembled — again revealing the unmodified original host version of # the hierarchy ("unmerging"). Merging thus makes the extension's # resources suddenly appear below the /usr/ and /opt/ hierarchies as if # they were included in the base OS image itself. Unmerging makes them # disappear again, leaving in place only the files that were shipped # with the base OS image itself. # # System configuration images are similar but operate on directories # containing system or service configuration. # # On nearly all modern distributions mount propagation plays a crucial # role and the rootfs of the OS is a shared mount in a peer group # (usually with peer group id 1): # # TARGET SOURCE FSTYPE PROPAGATION MNT_ID PARENT_ID # / / ext4 shared:1 29 1 # # On such systems all services and containers run in a separate mount # namespace and are pivot_root()ed into their rootfs. A separate mount # namespace is almost always used as it is the minimal isolation # mechanism services have. But usually they are even much more isolated # up to the point where they almost become indistinguishable from # containers. # # Mount propagation again plays a crucial role here. The rootfs of all # these services is a slave mount to the peer group of the host rootfs. # This is done so the service will receive mount propagation events from # the host when certain files or directories are updated. # # In addition, the rootfs of each service, container, and sandbox is # also a shared mount in its separate peer group: # # TARGET SOURCE FSTYPE PROPAGATION MNT_ID PARENT_ID # / / ext4 shared:24 master:1 71 47 # # For people not too familiar with mount propagation, the master:1 means # that this is a slave mount to peer group 1. Which as one can see is # the host rootfs as indicated by shared:1 above. The shared:24 # indicates that the service rootfs is a shared mount in a separate peer # group with peer group id 24. # # A service may run other services. Such nested services will also have # a rootfs mount that is a slave to the peer group of the outer service # rootfs mount. # # For containers things are just slighly different. A container's rootfs # isn't a slave to the service's or host rootfs' peer group. The rootfs # mount of a container is simply a shared mount in its own peer group: # # TARGET SOURCE FSTYPE PROPAGATION MNT_ID PARENT_ID # /home/ubuntu/debian-tree / ext4 shared:99 61 60 # # So whereas services are isolated OS components a container is treated # like a separate world and mount propagation into it is restricted to a # single well known mount that is a slave to the peer group of the # shared mount /run on the host: # # TARGET SOURCE FSTYPE PROPAGATION MNT_ID PARENT_ID # /propagate/debian-tree /run/host/incoming tmpfs master:5 71 68 # # Here, the master:5 indicates that this mount is a slave to the peer # group with peer group id 5. This allows to propagate mounts into the # container and served as a workaround for not being able to insert # mounts into mount namespaces directly. But the new mount api does # support inserting mounts directly. For the interested reader the # blogpost in [4] might be worth reading where I explain the old and the # new approach to inserting mounts into mount namespaces. # # Containers of course, can themselves be run as services. They often # run full systems themselves which means they again run services and # containers with the exact same propagation settings explained above. # # The whole system is designed so that it can be easily updated, # including all services in various fine-grained ways without having to # enter every single service's mount namespace which would be # prohibitively expensive. The mount propagation layout has been # carefully chosen so it is possible to propagate updates for system # extensions and configurations from the host into all services. # # The simplest model to update the whole system is to mount on top of # /usr, /opt, or /etc on the host. The new mount on /usr, /opt, or /etc # will then propagate into every service. This works cleanly the first # time. However, when the system is updated multiple times it becomes # necessary to unmount the first update on /opt, /usr, /etc and then # propagate the new update. But this means, there's an interval where # the old base system is accessible. This has to be avoided to protect # against downgrade attacks. # # The vfs already exposes a mechanism to userspace whereby mounts can be # mounted beneath an existing mount. Such mounts are internally referred # to as "tucked". The patch series exposes the ability to mount beneath # a top mount through the new MOVE_MOUNT_BENEATH flag for the # move_mount() system call. This allows userspace to seamlessly upgrade # mounts. After this series the only thing that will have changed is # that mounting beneath an existing mount can be done explicitly instead # of just implicitly. # # The crux is that the proposed mechanism already exists and that it is # so powerful as to cover cases where mounts are supposed to be updated # with new versions. Crucially, it offers an important flexibility. # Namely that updates to a system may either be forced or can be delayed # and the umount of the top mount be left to a service if it is a # cooperative one" # # Link: https://lwn.net/Articles/927491 [1] # Link: https://lwn.net/Articles/934094 [2] # Link: https://man7.org/linux/man-pages/man8/systemd-sysext.8.html [3] # Link: https://brauner.io/2023/02/28/mounting-into-mount-namespaces.html [4] # Link: https://github.com/flatcar/sysext-bakery # Link: https://fedoraproject.org/wiki/Changes/Unified_Kernel_Support_Phase_1 # Link: https://fedoraproject.org/wiki/Changes/Unified_Kernel_Support_Phase_2 # Link: https://github.com/systemd/systemd/pull/26013 # # * tag 'v6.5/vfs.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs: # fs: allow to mount beneath top mount # fs: use a for loop when locking a mount # fs: properly document __lookup_mnt() # fs: add path_mounted() # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 c0a572d9d32fe1e95672f24e860776dba0750a38 # make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- allmodconfig # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig # < make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- help # make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- olddefconfig # make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- In file included from /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:36:0: /kisskb/src/drivers/media/platform/nxp/imx-pxp.c: In function 'pxp_setup_csc': /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:375:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:375:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:392:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:392:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:409:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_rec709_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:409:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:426:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_rec709_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:426:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:443:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt2020_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:443:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:460:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt2020_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:460:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:477:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_smpte240m_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:477:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:494:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_smpte240m_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:494:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ make[6]: *** [/kisskb/src/scripts/Makefile.build:252: drivers/media/platform/nxp/imx-pxp.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/media/platform/nxp] Error 2 make[4]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/media/platform] Error 2 make[4]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/ufs/ufshcd.h:26:0, from /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:12: /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_40bit_rmmi': /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[15].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[16].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[28].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi_lane0': /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[8].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[9].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[19].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi': /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:286:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:288:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ make[5]: *** [/kisskb/src/scripts/Makefile.build:252: drivers/ufs/host/tc-dwc-g210.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/ufs/host] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/ufs] Error 2 make[3]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/media] Error 2 /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_mode_vba_31.c: In function 'UseMinimumDCFCLK': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_mode_vba_31.c:7179:1: error: the frame size of 2208 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] } ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c: In function 'UseMinimumDCFCLK': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:7224:1: error: the frame size of 2208 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] } ^ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:252: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn31/display_mode_vba_31.o] Error 1 make[6]: *** Waiting for unfinished jobs.... cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:252: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.o] Error 1 make[5]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/gpu/drm/amd/amdgpu] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/gpu/drm] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:494: drivers/gpu] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:494: drivers] Error 2 make[1]: *** [/kisskb/src/Makefile:2026: .] Error 2 make: *** [Makefile:226: __sub-make] Error 2 Command 'make -s -j 40 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_arm64-gcc5 # Build took: 0:08:05.678183