Buildresult: linus/s390-allnoconfig/s390x-gcc11 built on Jul 5 2023, 07:10

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 5 2023, 07:10
Duration:	0:00:50.869357
Builder:	blade4b
Revision:	afs: Fix accidental truncation when storing data (`03275585cabd0240944f19f33d7584a1b099a3a8)`
Target:	linus/s390-allnoconfig/s390x-gcc11
Branch:	linus
Compiler:	s390x-gcc11 (s390-linux-gcc (GCC) 11.3.0 / GNU ld (GNU Binutils) 2.38)
Config:	allnoconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 03275585cabd0240944f19f33d7584a1b099a3a8^{commit} 03275585cabd0240944f19f33d7584a1b099a3a8 already have revision, skipping fetch # git checkout -q -f -B kisskb 03275585cabd0240944f19f33d7584a1b099a3a8 # git clean -qxdf # < git log -1 # commit 03275585cabd0240944f19f33d7584a1b099a3a8 # Author: David Howells <dhowells@redhat.com> # Date: Tue Jul 4 20:22:15 2023 +0100 # # afs: Fix accidental truncation when storing data # # When an AFS FS.StoreData RPC call is made, amongst other things it is # given the resultant file size to be. On the server, this is processed # by truncating the file to new size and then writing the data. # # Now, kafs has a lock (vnode->io_lock) that serves to serialise # operations against a specific vnode (ie. inode), but the parameters for # the op are set before the lock is taken. This allows two writebacks # (say sync and kswapd) to race - and if writes are ongoing the writeback # for a later write could occur before the writeback for an earlier one if # the latter gets interrupted. # # Note that afs_writepages() cannot take i_mutex and only takes a shared # lock on vnode->validate_lock. # # Also note that the server does the truncation and the write inside a # lock, so there's no problem at that end. # # Fix this by moving the calculation for the proposed new i_size inside # the vnode->io_lock. Also reset the iterator (which we might have read # from) and update the mtime setting there. # # Fixes: bd80d8a80e12 ("afs: Use ITER_XARRAY for writing") # Reported-by: Marc Dionne <marc.dionne@auristor.com> # Signed-off-by: David Howells <dhowells@redhat.com> # Reviewed-by: Jeffrey Altman <jaltman@auristor.com> # Reviewed-by: Marc Dionne <marc.dionne@auristor.com> # cc: linux-afs@lists.infradead.org # cc: linux-fsdevel@vger.kernel.org # Link: https://lore.kernel.org/r/3526895.1687960024@warthog.procyon.org.uk/ # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux-ld --version # < git log --format=%s --max-count=1 03275585cabd0240944f19f33d7584a1b099a3a8 # make -s -j 24 ARCH=s390 O=/kisskb/build/linus_allnoconfig_s390x-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux- allnoconfig # < make -s -j 24 ARCH=s390 O=/kisskb/build/linus_allnoconfig_s390x-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux- help # make -s -j 24 ARCH=s390 O=/kisskb/build/linus_allnoconfig_s390x-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux- olddefconfig # make -s -j 24 ARCH=s390 O=/kisskb/build/linus_allnoconfig_s390x-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/s390-linux/bin/s390-linux- Completed OK # rm -rf /kisskb/build/linus_allnoconfig_s390x-gcc11 # Build took: 0:00:50.869357

© Michael Ellerman 2006-2018.