# git rev-parse -q --verify 03275585cabd0240944f19f33d7584a1b099a3a8^{commit}
03275585cabd0240944f19f33d7584a1b099a3a8
already have revision, skipping fetch
# git checkout -q -f -B kisskb 03275585cabd0240944f19f33d7584a1b099a3a8
# git clean -qxdf
# < git log -1
# commit 03275585cabd0240944f19f33d7584a1b099a3a8
# Author: David Howells <dhowells@redhat.com>
# Date:   Tue Jul 4 20:22:15 2023 +0100
# 
#     afs: Fix accidental truncation when storing data
#     
#     When an AFS FS.StoreData RPC call is made, amongst other things it is
#     given the resultant file size to be.  On the server, this is processed
#     by truncating the file to new size and then writing the data.
#     
#     Now, kafs has a lock (vnode->io_lock) that serves to serialise
#     operations against a specific vnode (ie.  inode), but the parameters for
#     the op are set before the lock is taken.  This allows two writebacks
#     (say sync and kswapd) to race - and if writes are ongoing the writeback
#     for a later write could occur before the writeback for an earlier one if
#     the latter gets interrupted.
#     
#     Note that afs_writepages() cannot take i_mutex and only takes a shared
#     lock on vnode->validate_lock.
#     
#     Also note that the server does the truncation and the write inside a
#     lock, so there's no problem at that end.
#     
#     Fix this by moving the calculation for the proposed new i_size inside
#     the vnode->io_lock.  Also reset the iterator (which we might have read
#     from) and update the mtime setting there.
#     
#     Fixes: bd80d8a80e12 ("afs: Use ITER_XARRAY for writing")
#     Reported-by: Marc Dionne <marc.dionne@auristor.com>
#     Signed-off-by: David Howells <dhowells@redhat.com>
#     Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
#     Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
#     cc: linux-afs@lists.infradead.org
#     cc: linux-fsdevel@vger.kernel.org
#     Link: https://lore.kernel.org/r/3526895.1687960024@warthog.procyon.org.uk/
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 03275585cabd0240944f19f33d7584a1b099a3a8
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  allyesconfig
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_MODULE_SIG=n
# < make -s -j 160 ARCH=sh O=/kisskb/build/linus_allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  help
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  olddefconfig
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S: Assembler messages:
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:85: Warning: overflow in branch to __restore_all; converted into longer instruction sequence
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:357: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
/kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:360: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence
/kisskb/src/drivers/char/mem.c: In function 'read_mem':
/kisskb/src/drivers/char/mem.c:164:25: error: implicit declaration of function 'unxlate_dev_mem_ptr'; did you mean 'xlate_dev_mem_ptr'? [-Werror=implicit-function-declaration]
  164 |                         unxlate_dev_mem_ptr(p, ptr);
      |                         ^~~~~~~~~~~~~~~~~~~
      |                         xlate_dev_mem_ptr
cc1: all warnings being treated as errors
make[5]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/char/mem.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/char] Error 2
make[4]: *** Waiting for unfinished jobs....
{standard input}: Assembler messages:
{standard input}: Warning: end of file not at end of a line; newline inserted
{standard input}:1097: Error: unknown pseudo-op: `.glo'
sh4-linux-gcc: internal compiler error: Segmentation fault signal terminated program cc1
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
make[6]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/net/pcs/pcs-xpcs.o] Error 4
make[5]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/net/pcs] Error 2
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/net] Error 2
make[3]: *** [/kisskb/src/scripts/Makefile.build:477: drivers] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [/kisskb/src/Makefile:2024: .] Error 2
make[1]: *** [/kisskb/src/Makefile:234: __sub-make] Error 2
make: *** [Makefile:234: __sub-make] Error 2
Command 'make -s -j 160 ARCH=sh O=/kisskb/build/linus_allyesconfig_sh4-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sh4-linux/bin/sh4-linux-  ' returned non-zero exit status 2.
# rm -rf /kisskb/build/linus_allyesconfig_sh4-gcc11
# Build took: 0:02:48.327950