# git rev-parse -q --verify 6cd06ab12d1afdab3847e7981f301bd0404aaa5c^{commit} 6cd06ab12d1afdab3847e7981f301bd0404aaa5c already have revision, skipping fetch # git checkout -q -f -B kisskb 6cd06ab12d1afdab3847e7981f301bd0404aaa5c # git clean -qxdf # < git log -1 # commit 6cd06ab12d1afdab3847e7981f301bd0404aaa5c # Author: Linus Torvalds # Date: Wed Jul 5 09:33:31 2023 -0700 # # gup: make the stack expansion warning a bit more targeted # # I added a warning about about GUP no longer expanding the stack in # commit a425ac5365f6 ("gup: add warning if some caller would seem to want # stack expansion"), but didn't really expect anybody to hit it. # # And it's true that nobody seems to have hit a _real_ case yet, but we # certainly have a number of reports of false positives. Which not only # causes extra noise in itself, but might also end up hiding any real # cases if they do exist. # # So let's tighten up the warning condition, and replace the simplistic # # vma = find_vma(mm, start); # if (vma && (start < vma->vm_start)) { # WARN_ON_ONCE(vma->vm_flags & VM_GROWSDOWN); # # with a # # vma = gup_vma_lookup(mm, start); # # helper function which works otherwise like just "vma_lookup()", but with # some heuristics for when to warn about gup no longer causing stack # expansion. # # In particular, don't just warn for "below the stack", but warn if it's # _just_ below the stack (with "just below" arbitrarily defined as 64kB, # because why not?). And rate-limit it to at most once per hour, which # means that any false positives shouldn't completely hide subsequent # reports, but we won't be flooding the logs about it either. # # The previous code triggered when some GUP user (chromium crashpad) # accessing past the end of the previous vma, for example. That has never # expanded the stack, it just causes GUP to return early, and as such we # shouldn't be warning about it. # # This is still going trigger the randomized testers, but to mitigate the # noise from that, use "dump_stack()" instead of "WARN_ON_ONCE()" to get # the kernel call chain. We'll get the relevant information, but syzbot # shouldn't get too upset about it. # # Also, don't even bother with the GROWSUP case, which would be using # different heuristics entirely, but only happens on parisc. # # Reported-by: kernel test robot # Reported-by: John Hubbard # Reported-by: syzbot+6cf44e127903fdf9d929@syzkaller.appspotmail.com # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 6cd06ab12d1afdab3847e7981f301bd0404aaa5c # make -s -j 160 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- allmodconfig # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig # < make -s -j 160 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- help # make -s -j 160 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- olddefconfig # make -s -j 160 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- In file included from /kisskb/src/include/ufs/ufshcd.h:26:0, from /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:12: /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_40bit_rmmi': /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:29:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:30:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:31:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0x80, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:32:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x08, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:33:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:34:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:35:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[15].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:52:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[16].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:53:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[28].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:76:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi_lane0': /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[8].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:109:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL10), 0x04, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[9].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:110:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(DIRECTCTRL19), 0x02, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[19].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:129:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGPLL2), 0x00, DME_LOCAL }, ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c: In function 'tc_dwc_g210_setup_20bit_rmmi': /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[0].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:225:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(TX_GLOBALHIBERNATE), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[1].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:226:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(REFCLKMODE), 0x01, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[2].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:227:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CDIRECTCTRL6), 0xc0, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[3].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:228:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDIVFACTOR), 0x44, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[4].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:229:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBDCOCTRL5), 0x64, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[5].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:230:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(CBPRGTUNING), 0x09, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: error: initializer element is not constant #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ /kisskb/src/include/ufs/ufshci.h:303:36: note: (near initialization for 'setup_attrs[6].attr_sel') #define UIC_ARG_MIB_SEL(attr, sel) ((((attr) & 0xFFFF) << 16) |\ ^ /kisskb/src/include/ufs/ufshci.h:305:28: note: in expansion of macro 'UIC_ARG_MIB_SEL' #define UIC_ARG_MIB(attr) UIC_ARG_MIB_SEL(attr, 0) ^ /kisskb/src/drivers/ufs/host/tc-dwc-g210.c:231:5: note: in expansion of macro 'UIC_ARG_MIB' { UIC_ARG_MIB(RTOBSERVESELECT), 0x00, DME_LOCAL }, ^ make[6]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/ufs/host/tc-dwc-g210.o] Error 1 make[5]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/ufs/host] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/ufs] Error 2 make[4]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:36:0: /kisskb/src/drivers/media/platform/nxp/imx-pxp.c: In function 'pxp_setup_csc': /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:375:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:375:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:392:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt601_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:392:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:409:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_rec709_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:409:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:426:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_rec709_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:426:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:443:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt2020_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:443:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:460:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_bt2020_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:460:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:477:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_smpte240m_lim[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:477:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: error: initializer element is not constant #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:494:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.h:582:38: note: (near initialization for 'csc1_coef_smpte240m_full[0]') #define BM_PXP_CSC1_COEF0_YCBCR_MODE 0x80000000 ^ /kisskb/src/drivers/media/platform/nxp/imx-pxp.c:494:4: note: in expansion of macro 'BM_PXP_CSC1_COEF0_YCBCR_MODE' BM_PXP_CSC1_COEF0_YCBCR_MODE | ^ make[7]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/media/platform/nxp/imx-pxp.o] Error 1 make[7]: *** Waiting for unfinished jobs.... make[6]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/media/platform/nxp] Error 2 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/media/platform] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:477: drivers/media] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:477: drivers] Error 2 make[2]: *** [/kisskb/src/Makefile:2020: .] Error 2 make[1]: *** [/kisskb/src/Makefile:234: __sub-make] Error 2 make: *** [Makefile:234: __sub-make] Error 2 Command 'make -s -j 160 ARCH=arm64 O=/kisskb/build/linus_allmodconfig_arm64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_arm64-gcc5 # Build took: 0:08:43.561605