# git rev-parse -q --verify 221a4b56ec70c1a9f09ce78751613d16c508a4ce^{commit} 221a4b56ec70c1a9f09ce78751613d16c508a4ce already have revision, skipping fetch # git checkout -q -f -B kisskb 221a4b56ec70c1a9f09ce78751613d16c508a4ce # git clean -qxdf # < git log -1 # commit 221a4b56ec70c1a9f09ce78751613d16c508a4ce # Author: Gustavo A. R. Silva # Date: Thu Jun 22 17:14:51 2023 -0600 # # sparc: openpromio: Address -Warray-bounds warning # # One-element arrays are deprecated, and we are replacing them with flexible # array members instead. So, replace one-element array with flexible-array # member in struct openpromio. # # Address the following warning found after building (with GCC-13) sparc # with sparc64_defconfig: # In function 'opromgetprop', # inlined from 'openprom_sunos_ioctl.isra' at drivers/sbus/char/openprom.c:312:11: # drivers/sbus/char/openprom.c:141:24: warning: array subscript 1 is above array bounds of 'char[1]' [-Warray-bounds=] # 141 | op->oprom_array[len] = '\0'; # | ~~~~~~~~~~~~~~~^~~~~ # In file included from drivers/sbus/char/openprom.c:31: # arch/sparc/include/uapi/asm/openpromio.h: In function 'openprom_sunos_ioctl.isra': # arch/sparc/include/uapi/asm/openpromio.h:16:17: note: while referencing 'oprom_array' # 16 | char oprom_array[1]; /* Holds property names and values. */ # | ^~~~~~~~~~~ # # This helps with the ongoing efforts to tighten the FORTIFY_SOURCE # routines on memcpy() and help us make progress towards globally # enabling -Warray-bounds. # # This results in no differences in binary output. # # Link: https://github.com/KSPP/linux/issues/79 # Link: https://github.com/KSPP/linux/issues/322 # Reviewed-by: Kees Cook # Signed-off-by: Gustavo A. R. Silva # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux-ld --version # < git log --format=%s --max-count=1 221a4b56ec70c1a9f09ce78751613d16c508a4ce # make -s -j 24 ARCH=s390 O=/kisskb/build/gustavoars_allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig # < make -s -j 24 ARCH=s390 O=/kisskb/build/gustavoars_allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux- help # make -s -j 24 ARCH=s390 O=/kisskb/build/gustavoars_allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux- olddefconfig # make -s -j 24 ARCH=s390 O=/kisskb/build/gustavoars_allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux- In file included from /kisskb/src/include/linux/string.h:254, from /kisskb/src/include/linux/bitmap.h:11, from /kisskb/src/include/linux/cpumask.h:12, from /kisskb/src/include/linux/smp.h:13, from /kisskb/src/include/linux/lockdep.h:14, from /kisskb/src/include/linux/rcupdate.h:29, from /kisskb/src/include/linux/rculist.h:11, from /kisskb/src/include/linux/pid.h:5, from /kisskb/src/include/linux/sched.h:14, from /kisskb/src/arch/s390/kernel/setup.c:21: In function 'strlcat', inlined from 'strcat' at /kisskb/src/include/linux/fortify-string.h:432:6, inlined from 'setup_zfcpdump' at /kisskb/src/arch/s390/kernel/setup.c:308:2, inlined from 'setup_arch' at /kisskb/src/arch/s390/kernel/setup.c:1008:2: /kisskb/src/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' offset -32 is out of the bounds of object 'boot_command_line' with type 'char[]' [-Werror=array-bounds] #define __underlying_memcpy __builtin_memcpy ^ /kisskb/src/include/linux/fortify-string.h:405:2: note: in expansion of macro '__underlying_memcpy' __underlying_memcpy(p + p_len, q, copy_len); ^~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/printk.h:6, from /kisskb/src/include/asm-generic/bug.h:22, from /kisskb/src/arch/s390/include/asm/bug.h:69, from /kisskb/src/include/linux/bug.h:5, from /kisskb/src/include/linux/mmdebug.h:5, from /kisskb/src/arch/s390/include/asm/cmpxchg.h:11, from /kisskb/src/arch/s390/include/asm/atomic.h:16, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/linux/rcupdate.h:25, from /kisskb/src/include/linux/rculist.h:11, from /kisskb/src/include/linux/pid.h:5, from /kisskb/src/include/linux/sched.h:14, from /kisskb/src/arch/s390/kernel/setup.c:21: /kisskb/src/arch/s390/kernel/setup.c: In function 'setup_arch': /kisskb/src/include/linux/init.h:146:24: note: 'boot_command_line' declared here extern char __initdata boot_command_line[]; ^~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:243: arch/s390/kernel/setup.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:477: arch/s390/kernel] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:477: arch/s390] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/Makefile:2020: .] Error 2 make[1]: *** [/kisskb/src/Makefile:234: __sub-make] Error 2 make: *** [Makefile:234: __sub-make] Error 2 Command 'make -s -j 24 ARCH=s390 O=/kisskb/build/gustavoars_allmodconfig_s390x-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/s390-linux/bin/s390-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/gustavoars_allmodconfig_s390x-gcc8 # Build took: 0:29:47.725992