# git rev-parse -q --verify 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e^{commit} 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e already have revision, skipping fetch # git checkout -q -f -B kisskb 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e # git clean -qxdf # < git log -1 # commit 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e # Author: Aneesh Kumar K.V # Date: Tue Oct 24 20:06:04 2023 +0530 # # powerpc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes # # With commit 9fee28baa601 ("powerpc: implement the new page table range # API") we added set_ptes to powerpc architecture. The implementation # included calling arch_enter/leave_lazy_mmu() calls. # # The patch removes the usage of arch_enter/leave_lazy_mmu() because # set_pte is not supposed to be used when updating a pte entry. Powerpc # architecture uses this rule to skip the expensive tlb invalidate which # is not needed when you are setting up the pte for the first time. See # commit 56eecdb912b5 ("mm: Use ptep/pmdp_set_numa() for updating # _PAGE_NUMA bit") for more details # # The patch also makes sure we are not using the interface to update a # valid/present pte entry by adding VM_WARN_ON check all the ptes we # are setting up. Furthermore, we add a comment to set_pte_filter to # clarify it can only update folio-related flags and cannot filter # pfn specific details in pte filtering. # # Removal of arch_enter/leave_lazy_mmu() also will avoid nesting of # these functions that are not supported. For ex: # # remap_pte_range() # -> arch_enter_lazy_mmu() # -> set_ptes() # -> arch_enter_lazy_mmu() # -> arch_leave_lazy_mmu() # -> arch_leave_lazy_mmu() # # Fixes: 9fee28baa601 ("powerpc: implement the new page table range API") # Signed-off-by: "Aneesh Kumar K.V" # Signed-off-by: Michael Ellerman # Link: https://msgid.link/20231024143604.16749-1-aneesh.kumar@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_smp_defconfig Using /kisskb/src/arch/powerpc/configs/mpc85xx_base.config as base Merging /kisskb/src/arch/powerpc/configs/85xx-32bit.config Merging /kisskb/src/arch/powerpc/configs/85xx-smp.config Merging /kisskb/src/arch/powerpc/configs/85xx-hw.config Merging /kisskb/src/arch/powerpc/configs/fsl-emb-nonhw.config # # merged configuration written to .config (needs make) # # < make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/build_bug.h:5:0, from /kisskb/src/include/linux/container_of.h:5, from /kisskb/src/include/linux/list.h:5, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:28:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:77:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:138:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: At top level: cc1: warning: unrecognized command line option '-Wno-shift-negative-value' Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 # Build took: 0:02:18.351254