# git rev-parse -q --verify 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e^{commit} 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e already have revision, skipping fetch # git checkout -q -f -B kisskb 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e # git clean -qxdf # < git log -1 # commit 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e # Author: Aneesh Kumar K.V # Date: Tue Oct 24 20:06:04 2023 +0530 # # powerpc/mm: Avoid calling arch_enter/leave_lazy_mmu() in set_ptes # # With commit 9fee28baa601 ("powerpc: implement the new page table range # API") we added set_ptes to powerpc architecture. The implementation # included calling arch_enter/leave_lazy_mmu() calls. # # The patch removes the usage of arch_enter/leave_lazy_mmu() because # set_pte is not supposed to be used when updating a pte entry. Powerpc # architecture uses this rule to skip the expensive tlb invalidate which # is not needed when you are setting up the pte for the first time. See # commit 56eecdb912b5 ("mm: Use ptep/pmdp_set_numa() for updating # _PAGE_NUMA bit") for more details # # The patch also makes sure we are not using the interface to update a # valid/present pte entry by adding VM_WARN_ON check all the ptes we # are setting up. Furthermore, we add a comment to set_pte_filter to # clarify it can only update folio-related flags and cannot filter # pfn specific details in pte filtering. # # Removal of arch_enter/leave_lazy_mmu() also will avoid nesting of # these functions that are not supported. For ex: # # remap_pte_range() # -> arch_enter_lazy_mmu() # -> set_ptes() # -> arch_enter_lazy_mmu() # -> arch_leave_lazy_mmu() # -> arch_leave_lazy_mmu() # # Fixes: 9fee28baa601 ("powerpc: implement the new page table range API") # Signed-off-by: "Aneesh Kumar K.V" # Signed-off-by: Michael Ellerman # Link: https://msgid.link/20231024143604.16749-1-aneesh.kumar@linux.ibm.com # < /opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 47b8def9358c5eb888e78b24b7e5b7f2e2e97b8e # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- pseries_defconfig Using /kisskb/src/arch/powerpc/configs/ppc64_defconfig as base Merging /kisskb/src/arch/powerpc/configs/le.config Merging /kisskb/src/arch/powerpc/configs/guest.config Value of CONFIG_VIRTIO_BLK is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_VIRTIO_BLK=m New value: CONFIG_VIRTIO_BLK=y Value of CONFIG_SCSI_VIRTIO is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_SCSI_VIRTIO=m New value: CONFIG_SCSI_VIRTIO=y Value of CONFIG_VIRTIO_NET is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_VIRTIO_NET=m New value: CONFIG_VIRTIO_NET=y Value of CONFIG_VIRTIO_CONSOLE is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_VIRTIO_CONSOLE=m New value: CONFIG_VIRTIO_CONSOLE=y Value of CONFIG_VIRTIO_PCI is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_VIRTIO_PCI=m New value: CONFIG_VIRTIO_PCI=y Value of CONFIG_VIRTIO_BALLOON is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_VIRTIO_BALLOON=m New value: CONFIG_VIRTIO_BALLOON=y Value of CONFIG_VHOST_NET is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_VHOST_NET=m New value: CONFIG_VHOST_NET=y Value of CONFIG_IBMVETH is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_IBMVETH=m New value: CONFIG_IBMVETH=y Value of CONFIG_IBMVNIC is redefined by fragment /kisskb/src/arch/powerpc/configs/guest.config: Previous value: CONFIG_IBMVNIC=m New value: CONFIG_IBMVNIC=y Merging /kisskb/src/arch/powerpc/configs/kvm_guest.config # # merged configuration written to .config (needs make) # # Added to kconfig CONFIG_PPC_POWERNV=n # < make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- gcc: error: /kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12/tools/objtool/libsubcmd/libsubcmd.a: No such file or directory make[4]: *** [Makefile:71: /kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12/tools/objtool/objtool] Error 1 make[3]: *** [Makefile:73: objtool] Error 2 make[2]: *** [/kisskb/src/Makefile:1355: tools/objtool] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:234: __sub-make] Error 2 make: *** [Makefile:234: __sub-make] Error 2 Command 'make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-12.2.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/powerpc-fixes_pseries_defconfig+POWERNV=n_powerpc-gcc12 # Build took: 0:00:24.995362