# git rev-parse -q --verify 021533194476035883300d60fbb3136426ac8ea5^{commit} 021533194476035883300d60fbb3136426ac8ea5 already have revision, skipping fetch # git checkout -q -f -B kisskb 021533194476035883300d60fbb3136426ac8ea5 # git clean -qxdf # < git log -1 # commit 021533194476035883300d60fbb3136426ac8ea5 # Author: Linus Torvalds # Date: Thu Feb 1 14:57:17 2024 -0800 # # Kconfig: Disable -Wstringop-overflow for GCC globally # # It turns out it was never just gcc-11 that was broken. Apparently it # just happens to work on x86-64 with other gcc versions. # # On arm64, I see warnings with gcc version 13.2.1, and the kernel test # robot reports the same problem on s390 with gcc 13.2.0. # # Admittedly it seems to be just the new Xe drm driver, but this is # keeping me from doing my normal arm64 build testing. So it gets # reverted until somebody figures out what causes the problem (and why it # doesn't show on x86-64, which is what makes me suspect it was never just # about gcc-11, and more about just random happenstance). # # This also changes the Kconfig naming a bit - just make the "disable this # for GCC" conditional be one simple Kconfig entry, and we can put the gcc # version dependencies in that entry once we figure out what the correct # rules are. # # The version dependency _may_ still end up being "gcc version larger than # 11" if the issue is purely in the Xe driver, but even if that ends up # the case, let's make that all part of the "GCC_NO_STRINGOP_OVERFLOW" # logic. # # For now, we just disable it for all gcc versions while the exact cause # is unknown. # # Link: https://lore.kernel.org/all/202401161031.hjGJHMiJ-lkp@intel.com/T/ # Cc: Gustavo A. R. Silva # Cc: Kees Cook # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 021533194476035883300d60fbb3136426ac8ea5 # make -s -j 40 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 allmodconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_KCOV=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n # Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n # Added to kconfig CONFIG_UML_NET=n # Added to kconfig CONFIG_UML_NET_ETHERTAP=n # Added to kconfig CONFIG_UML_NET_TUNTAP=n # Added to kconfig CONFIG_UML_NET_SLIP=n # Added to kconfig CONFIG_UML_NET_DAEMON=n # Added to kconfig CONFIG_UML_NET_VDE=n # Added to kconfig CONFIG_UML_NET_MCAST=n # Added to kconfig CONFIG_UML_NET_PCAP=n # Added to kconfig CONFIG_UML_NET_SLIRP=n # Added to kconfig CONFIG_GCOV_KERNEL=n # Added to kconfig CONFIG_DEBUG_INFO_BTF=n # Added to kconfig CONFIG_BPF_PRELOAD=n # Added to kconfig CONFIG_SPI_STM32_QSPI=n # < make -s -j 40 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 help # make -s -j 40 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 olddefconfig .config:14165:warning: override: reassigning to symbol GCC_PLUGIN_LATENT_ENTROPY .config:14169:warning: override: reassigning to symbol UML_NET_ETHERTAP .config:14171:warning: override: reassigning to symbol UML_NET_SLIP .config:14176:warning: override: reassigning to symbol UML_NET_SLIRP # make -s -j 40 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 /kisskb/src/arch/x86/um/user-offsets.c:17:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes] 17 | void foo(void) | ^~~ In file included from /kisskb/src/arch/um/kernel/asm-offsets.c:1: /kisskb/src/arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: error: no previous prototype for ‘foo’ [-Werror=missing-prototypes] 9 | void foo(void) | ^~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:116: arch/um/kernel/asm-offsets.s] Error 1 make[2]: *** [/kisskb/src/Makefile:1199: prepare0] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 40 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_um-x86_64-gcc12 # Build took: 0:00:17.800585