# git rev-parse -q --verify 4356e9f841f7fbb945521cef3577ba394c65f3fc^{commit} 4356e9f841f7fbb945521cef3577ba394c65f3fc already have revision, skipping fetch # git checkout -q -f -B kisskb 4356e9f841f7fbb945521cef3577ba394c65f3fc # git clean -qxdf # < git log -1 # commit 4356e9f841f7fbb945521cef3577ba394c65f3fc # Author: Linus Torvalds # Date: Fri Feb 9 12:39:31 2024 -0800 # # work around gcc bugs with 'asm goto' with outputs # # We've had issues with gcc and 'asm goto' before, and we created a # 'asm_volatile_goto()' macro for that in the past: see commits # 3f0116c3238a ("compiler/gcc4: Add quirk for 'asm goto' miscompilation # bug") and a9f180345f53 ("compiler/gcc4: Make quirk for # asm_volatile_goto() unconditional"). # # Then, much later, we ended up removing the workaround in commit # 43c249ea0b1e ("compiler-gcc.h: remove ancient workaround for gcc PR # 58670") because we no longer supported building the kernel with the # affected gcc versions, but we left the macro uses around. # # Now, Sean Christopherson reports a new version of a very similar # problem, which is fixed by re-applying that ancient workaround. But the # problem in question is limited to only the 'asm goto with outputs' # cases, so instead of re-introducing the old workaround as-is, let's # rename and limit the workaround to just that much less common case. # # It looks like there are at least two separate issues that all hit in # this area: # # (a) some versions of gcc don't mark the asm goto as 'volatile' when it # has outputs: # # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98619 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 # # which is easy to work around by just adding the 'volatile' by hand. # # (b) Internal compiler errors: # # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110422 # # which are worked around by adding the extra empty 'asm' as a # barrier, as in the original workaround. # # but the problem Sean sees may be a third thing since it involves bad # code generation (not an ICE) even with the manually added 'volatile'. # # but the same old workaround works for this case, even if this feels a # bit like voodoo programming and may only be hiding the issue. # # Reported-and-tested-by: Sean Christopherson # Link: https://lore.kernel.org/all/20240208220604.140859-1-seanjc@google.com/ # Cc: Nick Desaulniers # Cc: Uros Bizjak # Cc: Jakub Jelinek # Cc: Andrew Pinski # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version # < git log --format=%s --max-count=1 4356e9f841f7fbb945521cef3577ba394c65f3fc # make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux- allmodconfig # Added to kconfig CONFIG_64BIT=n # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MODULE_SIG=n # < make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux- help # make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux- olddefconfig # make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux- :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/arch/sparc/lib/cmpdi2.c:6:11: error: no previous prototype for '__cmpdi2' [-Werror=missing-prototypes] 6 | word_type __cmpdi2(long long a, long long b) | ^~~~~~~~ cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/lib/cmpdi2.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc/lib] Error 2 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/kernel/dma.c:70:5: error: no previous prototype for 'request_dma' [-Werror=missing-prototypes] 70 | int request_dma(unsigned int dmanr, const char * device_id) | ^~~~~~~~~~~ /kisskb/src/kernel/dma.c:88:6: error: no previous prototype for 'free_dma' [-Werror=missing-prototypes] 88 | void free_dma(unsigned int dmanr) | ^~~~~~~~ cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:243: kernel/dma.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:481: kernel] Error 2 /kisskb/src/drivers/mtd/maps/sun_uflash.c:50:5: error: no previous prototype for 'uflash_devinit' [-Werror=missing-prototypes] 50 | int uflash_devinit(struct platform_device *op, struct device_node *dp) | ^~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/mtd/maps/sun_uflash.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/mtd/maps] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/mtd] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:481: drivers] Error 2 make[2]: *** [/kisskb/src/Makefile:1921: .] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc11 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-11.3.0-nolibc/sparc64-linux/bin/sparc64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_sparc64-gcc11 # Build took: 0:04:49.957749