# git rev-parse -q --verify 4356e9f841f7fbb945521cef3577ba394c65f3fc^{commit}
4356e9f841f7fbb945521cef3577ba394c65f3fc
already have revision, skipping fetch
# git checkout -q -f -B kisskb 4356e9f841f7fbb945521cef3577ba394c65f3fc
# git clean -qxdf
# < git log -1
# commit 4356e9f841f7fbb945521cef3577ba394c65f3fc
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Fri Feb 9 12:39:31 2024 -0800
# 
#     work around gcc bugs with 'asm goto' with outputs
#     
#     We've had issues with gcc and 'asm goto' before, and we created a
#     'asm_volatile_goto()' macro for that in the past: see commits
#     3f0116c3238a ("compiler/gcc4: Add quirk for 'asm goto' miscompilation
#     bug") and a9f180345f53 ("compiler/gcc4: Make quirk for
#     asm_volatile_goto() unconditional").
#     
#     Then, much later, we ended up removing the workaround in commit
#     43c249ea0b1e ("compiler-gcc.h: remove ancient workaround for gcc PR
#     58670") because we no longer supported building the kernel with the
#     affected gcc versions, but we left the macro uses around.
#     
#     Now, Sean Christopherson reports a new version of a very similar
#     problem, which is fixed by re-applying that ancient workaround.  But the
#     problem in question is limited to only the 'asm goto with outputs'
#     cases, so instead of re-introducing the old workaround as-is, let's
#     rename and limit the workaround to just that much less common case.
#     
#     It looks like there are at least two separate issues that all hit in
#     this area:
#     
#      (a) some versions of gcc don't mark the asm goto as 'volatile' when it
#          has outputs:
#     
#             https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98619
#             https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420
#     
#          which is easy to work around by just adding the 'volatile' by hand.
#     
#      (b) Internal compiler errors:
#     
#             https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110422
#     
#          which are worked around by adding the extra empty 'asm' as a
#          barrier, as in the original workaround.
#     
#     but the problem Sean sees may be a third thing since it involves bad
#     code generation (not an ICE) even with the manually added 'volatile'.
#     
#     but the same old workaround works for this case, even if this feels a
#     bit like voodoo programming and may only be hiding the issue.
#     
#     Reported-and-tested-by: Sean Christopherson <seanjc@google.com>
#     Link: https://lore.kernel.org/all/20240208220604.140859-1-seanjc@google.com/
#     Cc: Nick Desaulniers <ndesaulniers@google.com>
#     Cc: Uros Bizjak <ubizjak@gmail.com>
#     Cc: Jakub Jelinek <jakub@redhat.com>
#     Cc: Andrew Pinski <quic_apinski@quicinc.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version
# < git log --format=%s --max-count=1 4356e9f841f7fbb945521cef3577ba394c65f3fc
# make -s -j 160 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  allmodconfig
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n
# Added to kconfig CONFIG_SAMPLES=n
# Added to kconfig CONFIG_MODULE_SIG=n
# < make -s -j 160 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  help
# make -s -j 160 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  olddefconfig
# make -s -j 160 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sparc/kernel/traps_64.c:253:6: error: no previous prototype for 'is_no_fault_exception' [-Werror=missing-prototypes]
  253 | bool is_no_fault_exception(struct pt_regs *regs)
      |      ^~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/kernel/traps_64.c:2035:6: error: no previous prototype for 'do_mcd_err' [-Werror=missing-prototypes]
 2035 | void do_mcd_err(struct pt_regs *regs, struct sun4v_error_entry ent)
      |      ^~~~~~~~~~
/kisskb/src/arch/sparc/kernel/traps_64.c:2153:6: error: no previous prototype for 'sun4v_nonresum_error_user_handled' [-Werror=missing-prototypes]
 2153 | bool sun4v_nonresum_error_user_handled(struct pt_regs *regs,
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/mm/init_64.c:2644:6: error: no previous prototype for 'vmemmap_free' [-Werror=missing-prototypes]
 2644 | void vmemmap_free(unsigned long start, unsigned long end,
      |      ^~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:254:1: error: no previous prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes]
  254 | __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
      | ^~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:282:1: error: no previous prototype for '__vdso_clock_gettime_stick' [-Werror=missing-prototypes]
  282 | __vdso_clock_gettime_stick(clockid_t clock, struct __kernel_old_timespec *ts)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:307:1: error: no previous prototype for '__vdso_gettimeofday' [-Werror=missing-prototypes]
  307 | __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
      | ^~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:343:1: error: no previous prototype for '__vdso_gettimeofday_stick' [-Werror=missing-prototypes]
  343 | __vdso_gettimeofday_stick(struct __kernel_old_timeval *tv, struct timezone *tz)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/vdso/vclock_gettime.o] Error 1
make[5]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[5]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/kernel/traps_64.o] Error 1
make[5]: *** Waiting for unfinished jobs....
/kisskb/src/arch/sparc/power/hibernate.c:22:5: error: no previous prototype for 'pfn_is_nosave' [-Werror=missing-prototypes]
   22 | int pfn_is_nosave(unsigned long pfn)
      |     ^~~~~~~~~~~~~
/kisskb/src/arch/sparc/power/hibernate.c:30:6: error: no previous prototype for 'save_processor_state' [-Werror=missing-prototypes]
   30 | void save_processor_state(void)
      |      ^~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/power/hibernate.c:35:6: error: no previous prototype for 'restore_processor_state' [-Werror=missing-prototypes]
   35 | void restore_processor_state(void)
      |      ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/power/hibernate.o] Error 1
make[3]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc/power] Error 2
make[3]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[5]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/mm/init_64.o] Error 1
make[5]: *** Waiting for unfinished jobs....
/kisskb/src/arch/sparc/vdso/vma.c:246:12: error: no previous prototype for 'init_vdso_image' [-Werror=missing-prototypes]
  246 | int __init init_vdso_image(const struct vdso_image *image,
      |            ^~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/prom/misc_64.c:165:5: error: no previous prototype for 'prom_get_mmu_ihandle' [-Werror=missing-prototypes]
  165 | int prom_get_mmu_ihandle(void)
      |     ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/prom/misc_64.o] Error 1
make[4]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[5]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/vdso/vma.o] Error 1
make[4]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc/kernel] Error 2
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc/mm] Error 2
make[4]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc/vdso] Error 2
/kisskb/src/arch/sparc/prom/p1275.c:52:6: error: no previous prototype for 'prom_cif_init' [-Werror=missing-prototypes]
   52 | void prom_cif_init(void *cif_handler, void *cif_stack)
      |      ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[4]: *** [/kisskb/src/scripts/Makefile.build:243: arch/sparc/prom/p1275.o] Error 1
make[3]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc/prom] Error 2
make[3]: *** [/kisskb/src/scripts/Makefile.build:481: arch/sparc] Error 2
In file included from /kisskb/src/arch/sparc/include/asm/floppy.h:5,
                 from /kisskb/src/drivers/block/floppy.c:250:
/kisskb/src/arch/sparc/include/asm/floppy_64.h:200:13: error: no previous prototype for 'sparc_floppy_irq' [-Werror=missing-prototypes]
  200 | irqreturn_t sparc_floppy_irq(int irq, void *dev_cookie)
      |             ^~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/include/asm/floppy_64.h:437:6: error: no previous prototype for 'sun_pci_fd_dma_callback' [-Werror=missing-prototypes]
  437 | void sun_pci_fd_dma_callback(struct ebus_dma_info *p, int event, void *cookie)
      |      ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[5]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/block/floppy.o] Error 1
make[5]: *** Waiting for unfinished jobs....
/kisskb/src/drivers/sbus/char/bbc_envctrl.c:566:5: error: no previous prototype for 'bbc_envctrl_init' [-Werror=missing-prototypes]
  566 | int bbc_envctrl_init(struct bbc_i2c_bus *bp)
      |     ^~~~~~~~~~~~~~~~
/kisskb/src/drivers/sbus/char/bbc_envctrl.c:594:6: error: no previous prototype for 'bbc_envctrl_cleanup' [-Werror=missing-prototypes]
  594 | void bbc_envctrl_cleanup(struct bbc_i2c_bus *bp)
      |      ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[6]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/sbus/char/bbc_envctrl.o] Error 1
make[5]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/sbus/char] Error 2
make[4]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/sbus] Error 2
make[4]: *** Waiting for unfinished jobs....
make[4]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/block] Error 2
make[3]: *** [/kisskb/src/scripts/Makefile.build:481: drivers] Error 2
make[2]: *** [/kisskb/src/Makefile:1921: .] Error 2
make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2
make: *** [Makefile:240: __sub-make] Error 2
Command 'make -s -j 160 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  ' returned non-zero exit status 2.
# rm -rf /kisskb/build/linus_allmodconfig_sparc64-gcc13
# Build took: 0:09:29.798963