# git rev-parse -q --verify 4356e9f841f7fbb945521cef3577ba394c65f3fc^{commit} 4356e9f841f7fbb945521cef3577ba394c65f3fc already have revision, skipping fetch # git checkout -q -f -B kisskb 4356e9f841f7fbb945521cef3577ba394c65f3fc # git clean -qxdf # < git log -1 # commit 4356e9f841f7fbb945521cef3577ba394c65f3fc # Author: Linus Torvalds # Date: Fri Feb 9 12:39:31 2024 -0800 # # work around gcc bugs with 'asm goto' with outputs # # We've had issues with gcc and 'asm goto' before, and we created a # 'asm_volatile_goto()' macro for that in the past: see commits # 3f0116c3238a ("compiler/gcc4: Add quirk for 'asm goto' miscompilation # bug") and a9f180345f53 ("compiler/gcc4: Make quirk for # asm_volatile_goto() unconditional"). # # Then, much later, we ended up removing the workaround in commit # 43c249ea0b1e ("compiler-gcc.h: remove ancient workaround for gcc PR # 58670") because we no longer supported building the kernel with the # affected gcc versions, but we left the macro uses around. # # Now, Sean Christopherson reports a new version of a very similar # problem, which is fixed by re-applying that ancient workaround. But the # problem in question is limited to only the 'asm goto with outputs' # cases, so instead of re-introducing the old workaround as-is, let's # rename and limit the workaround to just that much less common case. # # It looks like there are at least two separate issues that all hit in # this area: # # (a) some versions of gcc don't mark the asm goto as 'volatile' when it # has outputs: # # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98619 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 # # which is easy to work around by just adding the 'volatile' by hand. # # (b) Internal compiler errors: # # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110422 # # which are worked around by adding the extra empty 'asm' as a # barrier, as in the original workaround. # # but the problem Sean sees may be a third thing since it involves bad # code generation (not an ICE) even with the manually added 'volatile'. # # but the same old workaround works for this case, even if this feels a # bit like voodoo programming and may only be hiding the issue. # # Reported-and-tested-by: Sean Christopherson # Link: https://lore.kernel.org/all/20240208220604.140859-1-seanjc@google.com/ # Cc: Nick Desaulniers # Cc: Uros Bizjak # Cc: Jakub Jelinek # Cc: Andrew Pinski # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-ld --version # < git log --format=%s --max-count=1 4356e9f841f7fbb945521cef3577ba394c65f3fc # make -s -j 40 ARCH=mips O=/kisskb/build/linus_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- defconfig Using /kisskb/src/arch/mips/configs/generic_defconfig as base Merging /kisskb/src/arch/mips/configs/generic/32r2.config Merging /kisskb/src/arch/mips/configs/generic/el.config Merging /kisskb/src/arch/mips/configs/generic/board-boston.config Merging /kisskb/src/arch/mips/configs/generic/board-marduk.config Merging /kisskb/src/arch/mips/configs/generic/board-ni169445.config Merging /kisskb/src/arch/mips/configs/generic/board-ocelot.config Merging /kisskb/src/arch/mips/configs/generic/board-ranchu.config Merging /kisskb/src/arch/mips/configs/generic/board-sead-3.config Merging /kisskb/src/arch/mips/configs/generic/board-virt.config Merging /kisskb/src/arch/mips/configs/generic/board-xilfpga.config # < make -s -j 40 ARCH=mips O=/kisskb/build/linus_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- help # make -s -j 40 ARCH=mips O=/kisskb/build/linus_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- olddefconfig # make -s -j 40 ARCH=mips O=/kisskb/build/linus_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:836:20: error: initializer element is not constant { true, "TDPES0", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:836:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[0].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:837:20: error: initializer element is not constant { true, "TDPES1", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:837:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[1].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:838:20: error: initializer element is not constant { true, "TDPES2", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:838:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[2].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:839:20: error: initializer element is not constant { true, "TDPES3", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:839:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[3].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:840:20: error: initializer element is not constant { true, "TDPES4", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:840:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[4].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:841:20: error: initializer element is not constant { true, "TDPES5", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:841:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[5].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:842:20: error: initializer element is not constant { true, "TDPES6", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:842:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[6].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:843:20: error: initializer element is not constant { true, "TDPES7", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:843:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[7].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:844:20: error: initializer element is not constant { true, "TDPES8", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:844:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[8].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:845:20: error: initializer element is not constant { true, "TDPES9", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:845:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[9].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:846:21: error: initializer element is not constant { true, "TDPES10", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:846:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[10].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:847:21: error: initializer element is not constant { true, "TDPES11", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:847:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[11].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:848:21: error: initializer element is not constant { true, "TDPES12", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:848:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[12].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:849:21: error: initializer element is not constant { true, "TDPES13", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:849:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[13].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:850:21: error: initializer element is not constant { true, "TDPES14", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:850:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[14].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:851:21: error: initializer element is not constant { true, "TDPES15", dpp_tx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:851:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[15].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:852:20: error: initializer element is not constant { true, "RDPES0", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:852:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[16].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:853:20: error: initializer element is not constant { true, "RDPES1", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:853:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[17].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:854:20: error: initializer element is not constant { true, "RDPES2", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:854:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[18].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:855:20: error: initializer element is not constant { true, "RDPES3", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:855:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[19].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:856:20: error: initializer element is not constant { true, "RDPES4", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:856:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[20].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:857:20: error: initializer element is not constant { true, "RDPES5", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:857:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[21].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:858:20: error: initializer element is not constant { true, "RDPES6", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:858:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[22].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:859:20: error: initializer element is not constant { true, "RDPES7", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:859:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[23].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:860:20: error: initializer element is not constant { true, "RDPES8", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:860:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[24].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:861:20: error: initializer element is not constant { true, "RDPES9", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:861:20: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[25].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:862:21: error: initializer element is not constant { true, "RDPES10", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:862:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[26].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:863:21: error: initializer element is not constant { true, "RDPES11", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:863:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[27].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:864:21: error: initializer element is not constant { true, "RDPES12", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:864:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[28].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:865:21: error: initializer element is not constant { true, "RDPES13", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:865:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[29].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:866:21: error: initializer element is not constant { true, "RDPES14", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:866:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[30].detailed_desc’) /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:867:21: error: initializer element is not constant { true, "RDPES15", dpp_rx_err }, ^ /kisskb/src/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c:867:21: note: (near initialization for ‘dwxgmac3_dma_dpp_errors[31].detailed_desc’) cc1: warning: unrecognized command line option ‘-Wno-shift-negative-value’ cc1: warning: unrecognized command line option ‘-Wno-stringop-overflow’ make[8]: *** [/kisskb/src/scripts/Makefile.build:243: drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.o] Error 1 make[8]: *** Waiting for unfinished jobs.... make[7]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/net/ethernet/stmicro/stmmac] Error 2 make[6]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/net/ethernet/stmicro] Error 2 make[5]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/net/ethernet] Error 2 make[4]: *** [/kisskb/src/scripts/Makefile.build:481: drivers/net] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:481: drivers] Error 2 make[2]: *** [/kisskb/src/Makefile:1921: .] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 40 ARCH=mips O=/kisskb/build/linus_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_defconfig_mipsel-gcc5 # Build took: 0:01:00.581498