# git rev-parse -q --verify 0846dd77c8349ec92ca0079c9c71d130f34cb192^{commit}
0846dd77c8349ec92ca0079c9c71d130f34cb192
already have revision, skipping fetch
# git checkout -q -f -B kisskb 0846dd77c8349ec92ca0079c9c71d130f34cb192
# git clean -qxdf
# < git log -1
# commit 0846dd77c8349ec92ca0079c9c71d130f34cb192
# Author: Shivaprasad G Bhat <sbhat@linux.ibm.com>
# Date:   Tue Feb 13 10:05:22 2024 -0600
# 
#     powerpc/iommu: Fix the missing iommu_group_put() during platform domain attach
#     
#     The function spapr_tce_platform_iommu_attach_dev() is missing to call
#     iommu_group_put() when the domain is already set. This refcount leak
#     shows up with BUG_ON() during DLPAR remove operation as:
#     
#       KernelBug: Kernel bug in state 'None': kernel BUG at arch/powerpc/platforms/pseries/iommu.c:100!
#       Oops: Exception in kernel mode, sig: 5 [#1]
#       LE PAGE_SIZE=64K MMU=Radix SMP NR_CPUS=8192 NUMA pSeries
#       <snip>
#       Hardware name: IBM,9080-HEX POWER10 (raw) 0x800200 0xf000006 of:IBM,FW1060.00 (NH1060_016) hv:phyp pSeries
#       NIP:  c0000000000ff4d4 LR: c0000000000ff4cc CTR: 0000000000000000
#       REGS: c0000013aed5f840 TRAP: 0700   Tainted: G          I         (6.8.0-rc3-autotest-g99bd3cb0d12e)
#       MSR:  8000000000029033 <SF,EE,ME,IR,DR,RI,LE>  CR: 44002402  XER: 20040000
#       CFAR: c000000000a0d170 IRQMASK: 0
#       ...
#       NIP iommu_reconfig_notifier+0x94/0x200
#       LR  iommu_reconfig_notifier+0x8c/0x200
#       Call Trace:
#         iommu_reconfig_notifier+0x8c/0x200 (unreliable)
#         notifier_call_chain+0xb8/0x19c
#         blocking_notifier_call_chain+0x64/0x98
#         of_reconfig_notify+0x44/0xdc
#         of_detach_node+0x78/0xb0
#         ofdt_write.part.0+0x86c/0xbb8
#         proc_reg_write+0xf4/0x150
#         vfs_write+0xf8/0x488
#         ksys_write+0x84/0x140
#         system_call_exception+0x138/0x330
#         system_call_vectored_common+0x15c/0x2ec
#     
#     The patch adds the missing iommu_group_put() call.
#     
#     Fixes: a8ca9fc9134c ("powerpc/iommu: Do not do platform domain attach atctions after probe")
#     Reported-by: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
#     Closes: https://lore.kernel.org/all/274e0d2b-b5cc-475e-94e6-8427e88e271d@linux.vnet.ibm.com/
#     Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
#     Tested-by: Venkat Rao Bagalkote <venkat88@linux.vnet.ibm.com>
#     Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
#     Link: https://msgid.link/170784021983.6249.10039296655906636112.stgit@linux.ibm.com
# < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version
# < git log --format=%s --max-count=1 0846dd77c8349ec92ca0079c9c71d130f34cb192
# make -s -j 40 ARCH=sparc64 O=/kisskb/build/powerpc-fixes_defconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-  defconfig
# < make -s -j 40 ARCH=sparc64 O=/kisskb/build/powerpc-fixes_defconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-  help
# make -s -j 40 ARCH=sparc64 O=/kisskb/build/powerpc-fixes_defconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-  olddefconfig
# make -s -j 40 ARCH=sparc64 O=/kisskb/build/powerpc-fixes_defconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-  
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/vdso/vma.c:246:12: warning: no previous prototype for 'init_vdso_image' [-Wmissing-prototypes]
 int __init init_vdso_image(const struct vdso_image *image,
            ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:254:1: warning: no previous prototype for '__vdso_clock_gettime' [-Wmissing-prototypes]
 __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
 ^
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:282:1: warning: no previous prototype for '__vdso_clock_gettime_stick' [-Wmissing-prototypes]
 __vdso_clock_gettime_stick(clockid_t clock, struct __kernel_old_timespec *ts)
 ^
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:307:1: warning: no previous prototype for '__vdso_gettimeofday' [-Wmissing-prototypes]
 __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
 ^
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:343:1: warning: no previous prototype for '__vdso_gettimeofday_stick' [-Wmissing-prototypes]
 __vdso_gettimeofday_stick(struct __kernel_old_timeval *tv, struct timezone *tz)
 ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/mm/init_64.c:2644:6: warning: no previous prototype for 'vmemmap_free' [-Wmissing-prototypes]
 void vmemmap_free(unsigned long start, unsigned long end,
      ^
In file included from /kisskb/src/arch/sparc/vdso/vdso32/vclock_gettime.c:22:0:
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:254:1: warning: no previous prototype for '__vdso_clock_gettime' [-Wmissing-prototypes]
 __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
 ^
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:282:1: warning: no previous prototype for '__vdso_clock_gettime_stick' [-Wmissing-prototypes]
 __vdso_clock_gettime_stick(clockid_t clock, struct __kernel_old_timespec *ts)
 ^
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:307:1: warning: no previous prototype for '__vdso_gettimeofday' [-Wmissing-prototypes]
 __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
 ^
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:343:1: warning: no previous prototype for '__vdso_gettimeofday_stick' [-Wmissing-prototypes]
 __vdso_gettimeofday_stick(struct __kernel_old_timeval *tv, struct timezone *tz)
 ^
/kisskb/src/arch/sparc/kernel/traps_64.c:253:6: warning: no previous prototype for 'is_no_fault_exception' [-Wmissing-prototypes]
 bool is_no_fault_exception(struct pt_regs *regs)
      ^
/kisskb/src/arch/sparc/kernel/traps_64.c:2035:6: warning: no previous prototype for 'do_mcd_err' [-Wmissing-prototypes]
 void do_mcd_err(struct pt_regs *regs, struct sun4v_error_entry ent)
      ^
/kisskb/src/arch/sparc/kernel/traps_64.c:2153:6: warning: no previous prototype for 'sun4v_nonresum_error_user_handled' [-Wmissing-prototypes]
 bool sun4v_nonresum_error_user_handled(struct pt_regs *regs,
      ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/prom/misc_64.c:165:5: warning: no previous prototype for 'prom_get_mmu_ihandle' [-Wmissing-prototypes]
 int prom_get_mmu_ihandle(void)
     ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/prom/p1275.c:52:6: warning: no previous prototype for 'prom_cif_init' [-Wmissing-prototypes]
 void prom_cif_init(void *cif_handler, void *cif_stack)
      ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/kernel/setup_64.c:602:13: warning: no previous prototype for 'alloc_irqstack_bootmem' [-Wmissing-prototypes]
 void __init alloc_irqstack_bootmem(void)
             ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/kernel/time_64.c:880:20: warning: no previous prototype for 'sched_clock' [-Wmissing-prototypes]
 unsigned long long sched_clock(void)
                    ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/kernel/adi_64.c:124:21: warning: no previous prototype for 'find_tag_store' [-Wmissing-prototypes]
 tag_storage_desc_t *find_tag_store(struct mm_struct *mm,
                     ^
/kisskb/src/arch/sparc/kernel/adi_64.c:156:21: warning: no previous prototype for 'alloc_tag_store' [-Wmissing-prototypes]
 tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm,
                     ^
/kisskb/src/arch/sparc/kernel/adi_64.c:299:6: warning: no previous prototype for 'del_tag_store' [-Wmissing-prototypes]
 void del_tag_store(tag_storage_desc_t *tag_desc, struct mm_struct *mm)
      ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/kernel/pci_sun4v.c:259:15: warning: no previous prototype for 'dma_4v_iotsb_bind' [-Wmissing-prototypes]
 unsigned long dma_4v_iotsb_bind(unsigned long devhandle,
               ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
/kisskb/src/arch/sparc/kernel/uprobes.c:237:17: warning: no previous prototype for 'uprobe_trap' [-Wmissing-prototypes]
 asmlinkage void uprobe_trap(struct pt_regs *regs,
                 ^
cc1: warning: unrecognized command line option '-Wno-shift-negative-value'
WARNING: modpost: EXPORT symbol "_mcount" [vmlinux] version generation failed, symbol will not be versioned.
Is "_mcount" prototyped in <asm/asm-prototypes.h>?
Completed OK
# rm -rf /kisskb/build/powerpc-fixes_defconfig_sparc64-gcc5
# Build took: 0:00:47.823752