# git rev-parse -q --verify fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52^{commit} fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52 already have revision, skipping fetch # git checkout -q -f -B kisskb fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52 # git clean -qxdf # < git log -1 # commit fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52 # Author: Linus Torvalds # Date: Tue Feb 20 12:16:47 2024 -0800 # # drm/tests/drm_buddy: fix build failure on 32-bit targets # # Guenter Roeck reports that commit a64056bb5a32 ("drm/tests/drm_buddy: # add alloc_contiguous test") causes build failures on 32-bit targets: # # "This patch breaks the build on all 32-bit systems since it introduces # an unhandled direct 64-bit divide operation. # # ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined! # ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined!" # # and the uses of 'u64' are all entirely pointless. Yes, the arguments to # drm_buddy_init() and drm_buddy_alloc_blocks() are in fact of type 'u64', # but none of the values here are remotely relevant, and the compiler will # happily just do the type expansion. # # Of course, in a perfect world the compiler would also have just noticed # that all the values in question are tiny, and range analysis would have # shown that doing a 64-bit divide is pointless, but that is admittedly # expecting a fair amount of the compiler. # # IOW, we shouldn't write code that the compiler then has to notice is # unnecessarily complicated just to avoid extra work. We do have fairly # high expectations of compilers, but kernel code should be reasonable to # begin with. # # It turns out that there are also other issues with this code: the KUnit # assertion messages have incorrect types in the format strings, but # that's a widely spread issue caused by the KUnit infrastructure not # having enabled format string verification. We'll get that sorted out # separately. # # Reported-by: Guenter Roeck # Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test") # Link: https://lore.kernel.org/all/538327ff-8d34-41d5-a9ae-1a334744f5ae@roeck-us.net/ # Cc: Matthew Auld # Cc: Arunpravin Paneer Selvam # Cc: Christian König # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52 # make -s -j 32 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 allmodconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_KCOV=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n # Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n # Added to kconfig CONFIG_UML_NET=n # Added to kconfig CONFIG_UML_NET_ETHERTAP=n # Added to kconfig CONFIG_UML_NET_TUNTAP=n # Added to kconfig CONFIG_UML_NET_SLIP=n # Added to kconfig CONFIG_UML_NET_DAEMON=n # Added to kconfig CONFIG_UML_NET_VDE=n # Added to kconfig CONFIG_UML_NET_MCAST=n # Added to kconfig CONFIG_UML_NET_PCAP=n # Added to kconfig CONFIG_UML_NET_SLIRP=n # Added to kconfig CONFIG_GCOV_KERNEL=n # Added to kconfig CONFIG_DEBUG_INFO_BTF=n # Added to kconfig CONFIG_BPF_PRELOAD=n # Added to kconfig CONFIG_SPI_STM32_QSPI=n # < make -s -j 32 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 help # make -s -j 32 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 olddefconfig .config:14167:warning: override: reassigning to symbol GCC_PLUGIN_LATENT_ENTROPY .config:14171:warning: override: reassigning to symbol UML_NET_ETHERTAP .config:14173:warning: override: reassigning to symbol UML_NET_SLIP .config:14178:warning: override: reassigning to symbol UML_NET_SLIRP # make -s -j 32 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 /kisskb/src/arch/x86/um/user-offsets.c:17:6: warning: no previous prototype for ‘foo’ [-Wmissing-prototypes] 17 | void foo(void) | ^~~ In file included from /kisskb/src/arch/um/kernel/asm-offsets.c:1: /kisskb/src/arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: error: no previous prototype for ‘foo’ [-Werror=missing-prototypes] 9 | void foo(void) | ^~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:116: arch/um/kernel/asm-offsets.s] Error 1 make[2]: *** [/kisskb/src/Makefile:1199: prepare0] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 32 ARCH=um O=/kisskb/build/linus_allmodconfig_um-x86_64-gcc12 CROSS_COMPILE=/opt/cross/kisskb/x86-64--glibc--bleeding-edge-2022.08-1/bin/x86_64-linux- SUBARCH=x86_64 ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_um-x86_64-gcc12 # Build took: 0:00:08.890757