# git rev-parse -q --verify fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52^{commit}
fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52
already have revision, skipping fetch
# git checkout -q -f -B kisskb fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52
# git clean -qxdf
# < git log -1
# commit fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Tue Feb 20 12:16:47 2024 -0800
# 
#     drm/tests/drm_buddy: fix build failure on 32-bit targets
#     
#     Guenter Roeck reports that commit a64056bb5a32 ("drm/tests/drm_buddy:
#     add alloc_contiguous test") causes build failures on 32-bit targets:
#     
#      "This patch breaks the build on all 32-bit systems since it introduces
#       an unhandled direct 64-bit divide operation.
#     
#       ERROR: modpost: "__umoddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined!
#       ERROR: modpost: "__moddi3" [drivers/gpu/drm/tests/drm_buddy_test.ko] undefined!"
#     
#     and the uses of 'u64' are all entirely pointless.  Yes, the arguments to
#     drm_buddy_init() and drm_buddy_alloc_blocks() are in fact of type 'u64',
#     but none of the values here are remotely relevant, and the compiler will
#     happily just do the type expansion.
#     
#     Of course, in a perfect world the compiler would also have just noticed
#     that all the values in question are tiny, and range analysis would have
#     shown that doing a 64-bit divide is pointless, but that is admittedly
#     expecting a fair amount of the compiler.
#     
#     IOW, we shouldn't write code that the compiler then has to notice is
#     unnecessarily complicated just to avoid extra work.  We do have fairly
#     high expectations of compilers, but kernel code should be reasonable to
#     begin with.
#     
#     It turns out that there are also other issues with this code: the KUnit
#     assertion messages have incorrect types in the format strings, but
#     that's a widely spread issue caused by the KUnit infrastructure not
#     having enabled format string verification.  We'll get that sorted out
#     separately.
#     
#     Reported-by: Guenter Roeck <linux@roeck-us.net>
#     Fixes: a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test")
#     Link: https://lore.kernel.org/all/538327ff-8d34-41d5-a9ae-1a334744f5ae@roeck-us.net/
#     Cc: Matthew Auld <matthew.auld@intel.com>
#     Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
#     Cc: Christian König <christian.koenig@amd.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version
# < git log --format=%s --max-count=1 fca7526b7d8910c6125cb1ebc3e78ccd5f50ec52
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_se7750_defconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-  se7750_defconfig
# < make -s -j 160 ARCH=sh O=/kisskb/build/linus_se7750_defconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-  help
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_se7750_defconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-  olddefconfig
# make -s -j 160 ARCH=sh O=/kisskb/build/linus_se7750_defconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-  
  Generating include/generated/machtypes.h
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sh/mm/pgtable.c:10:6: warning: no previous prototype for 'pgd_ctor' [-Wmissing-prototypes]
   10 | void pgd_ctor(void *x)
      |      ^~~~~~~~
/kisskb/src/arch/sh/mm/pgtable.c:32:8: warning: no previous prototype for 'pgd_alloc' [-Wmissing-prototypes]
   32 | pgd_t *pgd_alloc(struct mm_struct *mm)
      |        ^~~~~~~~~
/kisskb/src/arch/sh/mm/pgtable.c:37:6: warning: no previous prototype for 'pgd_free' [-Wmissing-prototypes]
   37 | void pgd_free(struct mm_struct *mm, pgd_t *pgd)
      |      ^~~~~~~~
/kisskb/src/arch/sh/mm/flush-sh4.c:106:13: warning: no previous prototype for 'sh4__flush_region_init' [-Wmissing-prototypes]
  106 | void __init sh4__flush_region_init(void)
      |             ^~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sh/mm/tlbex_32.c:22:1: warning: no previous prototype for 'handle_tlbmiss' [-Wmissing-prototypes]
   22 | handle_tlbmiss(struct pt_regs *regs, unsigned long error_code,
      | ^~~~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/init.c:99:29: warning: no previous prototype for 'l2_cache_init' [-Wmissing-prototypes]
   99 | void __attribute__ ((weak)) l2_cache_init(void)
      |                             ^~~~~~~~~~~~~
/kisskb/src/arch/sh/mm/cache-sh4.c:384:13: warning: no previous prototype for 'sh4_cache_init' [-Wmissing-prototypes]
  384 | void __init sh4_cache_init(void)
      |             ^~~~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4/fpu.c:389:6: warning: no previous prototype for 'float_raise' [-Wmissing-prototypes]
  389 | void float_raise(unsigned int flags)
      |      ^~~~~~~~~~~
/kisskb/src/arch/sh/kernel/cpu/sh4/fpu.c:394:5: warning: no previous prototype for 'float_rounding_mode' [-Wmissing-prototypes]
  394 | int float_rounding_mode(void)
      |     ^~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/return_address.c:49:7: warning: no previous prototype for 'return_address' [-Wmissing-prototypes]
   49 | void *return_address(unsigned int depth)
      |       ^~~~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/sys_sh.c:58:16: warning: no previous prototype for 'sys_cacheflush' [-Wmissing-prototypes]
   58 | asmlinkage int sys_cacheflush(unsigned long addr, unsigned long len, int op)
      |                ^~~~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/traps_32.c:735:6: warning: no previous prototype for 'per_cpu_trap_init' [-Wmissing-prototypes]
  735 | void per_cpu_trap_init(void)
      |      ^~~~~~~~~~~~~~~~~
/kisskb/src/arch/sh/kernel/hw_breakpoint.c:135:5: warning: no previous prototype for 'arch_bp_generic_fields' [-Wmissing-prototypes]
  135 | int arch_bp_generic_fields(int sh_len, int sh_type,
      |     ^~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sh/boot/compressed/cache.c:2:5: warning: no previous prototype for 'cache_control' [-Wmissing-prototypes]
    2 | int cache_control(unsigned int command)
      |     ^~~~~~~~~~~~~
/kisskb/src/arch/sh/boot/compressed/misc.c:115:6: warning: no previous prototype for 'ftrace_stub' [-Wmissing-prototypes]
  115 | void ftrace_stub(void)
      |      ^~~~~~~~~~~
/kisskb/src/arch/sh/boot/compressed/misc.c:118:6: warning: no previous prototype for 'arch_ftrace_ops_list_func' [-Wmissing-prototypes]
  118 | void arch_ftrace_ops_list_func(void)
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sh/boot/compressed/misc.c:128:6: warning: no previous prototype for 'decompress_kernel' [-Wmissing-prototypes]
  128 | void decompress_kernel(void)
      |      ^~~~~~~~~~~~~~~~~
  Kernel: arch/sh/boot/zImage is ready
Completed OK
# rm -rf /kisskb/build/linus_se7750_defconfig_sh4-gcc13
# Build took: 0:01:04.418242