Buildresult: linus/x86_64-defconfig/x86_64-gcc8 built on Mar 28, 04:13

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Mar 28, 04:13
Duration:	0:03:03.452523
Builder:	alpine2
Revision:	Fix build errors due to new UIO_MEM_DMA_COHERENT mess (`498e47cd1d1f3e0a870a29d1b28093e64db52fd2)`
Target:	linus/x86_64-defconfig/x86_64-gcc8
Branch:	linus
Compiler:	x86_64-gcc8 (x86_64-linux-gcc (GCC) 8.5.0 / GNU ld (GNU Binutils) 2.36.1)
Config:	defconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 498e47cd1d1f3e0a870a29d1b28093e64db52fd2^{commit} 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 already have revision, skipping fetch # git checkout -q -f -B kisskb 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 # git clean -qxdf # < git log -1 # commit 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Wed Mar 27 09:48:47 2024 -0700 # # Fix build errors due to new UIO_MEM_DMA_COHERENT mess # # Commit 576882ef5e7f ("uio: introduce UIO_MEM_DMA_COHERENT type") # introduced a new use-case for 'struct uio_mem' where the 'mem' field now # contains a kernel virtual address when 'memtype' is set to # UIO_MEM_DMA_COHERENT. # # That in turn causes build errors, because 'mem' is of type # 'phys_addr_t', and a virtual address is a pointer type. When the code # just blindly uses cast to mix the two, it caused problems when # phys_addr_t isn't the same size as a pointer - notably on 32-bit # architectures with PHYS_ADDR_T_64BIT. # # The proper thing to do would probably be to use a union member, and not # have any casts, and make the 'mem' member be a union of 'mem.physaddr' # and 'mem.vaddr', based on 'memtype'. # # This is not that proper thing. This is just fixing the ugly casts to be # even uglier, but at least not cause build errors on 32-bit platforms # with 64-bit physical addresses. # # Reported-by: Guenter Roeck <linux@roeck-us.net> # Fixes: 576882ef5e7f ("uio: introduce UIO_MEM_DMA_COHERENT type") # Fixes: 7722151e4651 ("uio_pruss: UIO_MEM_DMA_COHERENT conversion") # Fixes: 019947805a8d ("uio_dmem_genirq: UIO_MEM_DMA_COHERENT conversion") # Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> # Cc: Chris Leech <cleech@redhat.com> # Cc: Nilesh Javali <njavali@marvell.com> # Cc: Christoph Hellwig <hch@lst.de> # Signed-off-by: Linus Torvalds <torvalds@linuxfoundation.org> # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 # make -s -j 160 ARCH=x86_64 O=/kisskb/build/linus_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- defconfig # < make -s -j 160 ARCH=x86_64 O=/kisskb/build/linus_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 160 ARCH=x86_64 O=/kisskb/build/linus_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 160 ARCH=x86_64 O=/kisskb/build/linus_defconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/linus_defconfig_x86_64-gcc8 # Build took: 0:03:03.452523

© Michael Ellerman 2006-2018.