# git rev-parse -q --verify 498e47cd1d1f3e0a870a29d1b28093e64db52fd2^{commit} 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 already have revision, skipping fetch # git checkout -q -f -B kisskb 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 # git clean -qxdf # < git log -1 # commit 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 # Author: Linus Torvalds # Date: Wed Mar 27 09:48:47 2024 -0700 # # Fix build errors due to new UIO_MEM_DMA_COHERENT mess # # Commit 576882ef5e7f ("uio: introduce UIO_MEM_DMA_COHERENT type") # introduced a new use-case for 'struct uio_mem' where the 'mem' field now # contains a kernel virtual address when 'memtype' is set to # UIO_MEM_DMA_COHERENT. # # That in turn causes build errors, because 'mem' is of type # 'phys_addr_t', and a virtual address is a pointer type. When the code # just blindly uses cast to mix the two, it caused problems when # phys_addr_t isn't the same size as a pointer - notably on 32-bit # architectures with PHYS_ADDR_T_64BIT. # # The proper thing to do would probably be to use a union member, and not # have any casts, and make the 'mem' member be a union of 'mem.physaddr' # and 'mem.vaddr', based on 'memtype'. # # This is not that proper thing. This is just fixing the ugly casts to be # even uglier, but at least not cause build errors on 32-bit platforms # with 64-bit physical addresses. # # Reported-by: Guenter Roeck # Fixes: 576882ef5e7f ("uio: introduce UIO_MEM_DMA_COHERENT type") # Fixes: 7722151e4651 ("uio_pruss: UIO_MEM_DMA_COHERENT conversion") # Fixes: 019947805a8d ("uio_dmem_genirq: UIO_MEM_DMA_COHERENT conversion") # Cc: Greg Kroah-Hartman # Cc: Chris Leech # Cc: Nilesh Javali # Cc: Christoph Hellwig # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 498e47cd1d1f3e0a870a29d1b28093e64db52fd2 # make -s -j 160 ARCH=mips O=/kisskb/build/linus_32r6el_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/mips-linux/bin/mips-linux- 32r6el_defconfig Using /kisskb/src/arch/mips/configs/generic_defconfig as base Merging /kisskb/src/arch/mips/configs/generic/32r6.config Merging /kisskb/src/arch/mips/configs/generic/el.config Merging /kisskb/src/arch/mips/configs/generic/board-boston.config Merging /kisskb/src/arch/mips/configs/generic/board-marduk.config Merging /kisskb/src/arch/mips/configs/generic/board-ranchu.config Merging /kisskb/src/arch/mips/configs/generic/board-sead-3.config Merging /kisskb/src/arch/mips/configs/generic/board-virt.config # < make -s -j 160 ARCH=mips O=/kisskb/build/linus_32r6el_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/mips-linux/bin/mips-linux- help # make -s -j 160 ARCH=mips O=/kisskb/build/linus_32r6el_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/mips-linux/bin/mips-linux- olddefconfig # make -s -j 160 ARCH=mips O=/kisskb/build/linus_32r6el_defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/boot/dts/img/boston.dts:128.17-178.5: Warning (interrupt_provider): /pci@14000000/pci2_root@0,0: '#interrupt-cells' found, but node is not an interrupt provider /kisskb/src/arch/mips/boot/dts/img/boston.dts:136.23-177.6: Warning (interrupt_provider): /pci@14000000/pci2_root@0,0/eg20t_bridge@1,0,0: '#interrupt-cells' found, but node is not an interrupt provider arch/mips/boot/dts/img/boston.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider' Completed OK # rm -rf /kisskb/build/linus_32r6el_defconfig_mips-gcc8 # Build took: 0:01:21.418596