# git rev-parse -q --verify 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e^{commit} 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e already have revision, skipping fetch # git checkout -q -f -B kisskb 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e # git clean -qxdf # < git log -1 # commit 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e # Author: Arnd Bergmann # Date: Tue Apr 16 17:33:01 2024 +0200 # # powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n # # Calling inb()/outb() on powerpc when CONFIG_PCI is disabled causes # a NULL pointer dereference, which is bad for a number of reasons. # # After my patch to turn on -Werror in linux-next, this caused a # compiler-time warning with clang: # # In file included from arch/powerpc/include/asm/io.h:672: # arch/powerpc/include/asm/io-defs.h:43:1: error: performing pointer # arithmetic on a null pointer has undefined behavior # [-Werror,-Wnull-pointer-arithmetic] # 43 | DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c), # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # 44 | (p, b, c), pio, p) # | ~~~~~~~~~~~~~~~~~~ # # In this configuration, CONFIG_HAS_IOPORT is already disabled, and all # drivers that use inb()/outb() should now depend on that (some patches are # still in the process of getting marged). # # Hide all references to inb()/outb() in the powerpc code and the definitions # when HAS_IOPORT is disabled to remove the possible NULL pointer access. # The same should happin in asm-generic in the near future, but for now # the empty inb() macros are still defined to ensure the generic version # does not get pulled in. # # Signed-off-by: Arnd Bergmann # Reported-by: Naresh Kamboju # Closes: https://lore.kernel.org/all/CA+G9fYtEh8zmq8k8wE-8RZwW-Qr927RLTn+KqGnq1F=ptaaNsA@mail.gmail.com # Signed-off-by: Michael Ellerman # Link: https://msgid.link/20240416153331.1617772-1-arnd@kernel.org # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc86xx_defconfig Using /kisskb/src/arch/powerpc/configs/mpc86xx_base.config as base Merging /kisskb/src/arch/powerpc/configs/86xx-hw.config Merging /kisskb/src/arch/powerpc/configs/fsl-emb-nonhw.config # # merged configuration written to .config (needs make) # # < make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:135.22-137.4: Warning (pci_bridge): /pcie@f1008000: missing ranges for PCI bridge (or not a bridge) also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:92.7-117.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:102.9-116.4: Warning (pci_bridge): /pcie@f1008000/pcie@0: missing ranges for PCI bridge (or not a bridge) /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:139.22-141.4: Warning (pci_bridge): /pcie@f1009000: missing ranges for PCI bridge (or not a bridge) also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:119.7-144.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:129.9-143.4: Warning (pci_bridge): /pcie@f1009000/pcie@0: missing ranges for PCI bridge (or not a bridge) arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (unit_address_format): Failed prerequisite 'pci_bridge' arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (pci_device_reg): Failed prerequisite 'pci_bridge' arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:30.11-32.6: Warning (i2c_bus_reg): /soc@f1000000/i2c@3000/rtc@68: missing or empty reg property /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:135.22-137.4: Warning (interrupt_provider): /pcie@f1008000: '#interrupt-cells' found, but node is not an interrupt provider also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:92.7-117.3 /kisskb/src/arch/powerpc/boot/dts/fsl/mvme7100.dts:139.22-141.4: Warning (interrupt_provider): /pcie@f1009000: '#interrupt-cells' found, but node is not an interrupt provider also defined at /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8641si-post.dtsi:119.7-144.3 arch/powerpc/boot/dts/fsl/mvme7100.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider' Completed OK # rm -rf /kisskb/build/powerpc-next_mpc86xx_defconfig_powerpc-gcc5 # Build took: 0:01:08.063093