# git rev-parse -q --verify 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e^{commit} 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e already have revision, skipping fetch # git checkout -q -f -B kisskb 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e # git clean -qxdf # < git log -1 # commit 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e # Author: Arnd Bergmann # Date: Tue Apr 16 17:33:01 2024 +0200 # # powerpc: drop port I/O helpers for CONFIG_HAS_IOPORT=n # # Calling inb()/outb() on powerpc when CONFIG_PCI is disabled causes # a NULL pointer dereference, which is bad for a number of reasons. # # After my patch to turn on -Werror in linux-next, this caused a # compiler-time warning with clang: # # In file included from arch/powerpc/include/asm/io.h:672: # arch/powerpc/include/asm/io-defs.h:43:1: error: performing pointer # arithmetic on a null pointer has undefined behavior # [-Werror,-Wnull-pointer-arithmetic] # 43 | DEF_PCI_AC_NORET(insb, (unsigned long p, void *b, unsigned long c), # | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # 44 | (p, b, c), pio, p) # | ~~~~~~~~~~~~~~~~~~ # # In this configuration, CONFIG_HAS_IOPORT is already disabled, and all # drivers that use inb()/outb() should now depend on that (some patches are # still in the process of getting marged). # # Hide all references to inb()/outb() in the powerpc code and the definitions # when HAS_IOPORT is disabled to remove the possible NULL pointer access. # The same should happin in asm-generic in the near future, but for now # the empty inb() macros are still defined to ensure the generic version # does not get pulled in. # # Signed-off-by: Arnd Bergmann # Reported-by: Naresh Kamboju # Closes: https://lore.kernel.org/all/CA+G9fYtEh8zmq8k8wE-8RZwW-Qr927RLTn+KqGnq1F=ptaaNsA@mail.gmail.com # Signed-off-by: Michael Ellerman # Link: https://msgid.link/20240416153331.1617772-1-arnd@kernel.org # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-ld --version # < git log --format=%s --max-count=1 3cfdbc2274139bbcc09a44f8aa18d08c0abfd51e # make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-next_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- defconfig Using /kisskb/src/arch/mips/configs/generic_defconfig as base Merging /kisskb/src/arch/mips/configs/generic/32r2.config Merging /kisskb/src/arch/mips/configs/generic/el.config Merging /kisskb/src/arch/mips/configs/generic/board-boston.config Merging /kisskb/src/arch/mips/configs/generic/board-marduk.config Merging /kisskb/src/arch/mips/configs/generic/board-ni169445.config Merging /kisskb/src/arch/mips/configs/generic/board-ocelot.config Merging /kisskb/src/arch/mips/configs/generic/board-ranchu.config Merging /kisskb/src/arch/mips/configs/generic/board-sead-3.config Merging /kisskb/src/arch/mips/configs/generic/board-virt.config Merging /kisskb/src/arch/mips/configs/generic/board-xilfpga.config # < make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-next_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- help # make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-next_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- olddefconfig # make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-next_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- /kisskb/src/arch/mips/boot/dts/img/boston.dts:128.17-178.5: Warning (interrupt_provider): /pci@14000000/pci2_root@0,0: '#interrupt-cells' found, but node is not an interrupt provider /kisskb/src/arch/mips/boot/dts/img/boston.dts:136.23-177.6: Warning (interrupt_provider): /pci@14000000/pci2_root@0,0/eg20t_bridge@1,0,0: '#interrupt-cells' found, but node is not an interrupt provider arch/mips/boot/dts/img/boston.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider' Completed OK # rm -rf /kisskb/build/powerpc-next_defconfig_mipsel-gcc5 # Build took: 0:01:00.313172