# git rev-parse -q --verify 4a4be1ad3a6efea16c56615f31117590fd881358^{commit} 4a4be1ad3a6efea16c56615f31117590fd881358 already have revision, skipping fetch # git checkout -q -f -B kisskb 4a4be1ad3a6efea16c56615f31117590fd881358 # git clean -qxdf # < git log -1 # commit 4a4be1ad3a6efea16c56615f31117590fd881358 # Author: Linus Torvalds # Date: Wed May 29 09:39:34 2024 -0700 # # Revert "vfs: Delete the associated dentry when deleting a file" # # This reverts commit 681ce8623567ba7e7333908e9826b77145312dda. # # We gave it a try, but it turns out the kernel test robot did in fact # find performance regressions for it, so we'll have to look at the more # involved alternative fixes for Yafang Shao's Elasticsearch load issue. # # There were several alternatives discussed, they just weren't as simple # as this first attempt. # # The report is of a -7.4% regression of filebench.sum_operations/s, which # appears significant enough to trigger my "this patch may get reverted if # somebody finds a performance regression on some other load" rule. # # So it's still the case that we should end up deleting dentries more # aggressively - or just be better at pruning them later - but it needs a # bit more finesse than this simple thing. # # Link: https://lore.kernel.org/all/202405291318.4dfbb352-oliver.sang@intel.com/ # Cc: Yafang Shao # Cc: Al Viro # Cc: Christian Brauner # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version # < git log --format=%s --max-count=1 4a4be1ad3a6efea16c56615f31117590fd881358 # make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux- allmodconfig # Added to kconfig CONFIG_64BIT=n # Added to kconfig # < make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux- help # make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux- olddefconfig # make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux- :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] In file included from /kisskb/src/include/asm-generic/bug.h:22, from /kisskb/src/arch/sparc/include/asm/bug.h:25, from /kisskb/src/include/linux/bug.h:5, from /kisskb/src/include/linux/alloc_tag.h:8, from /kisskb/src/include/linux/vmalloc.h:5, from /kisskb/src/drivers/scsi/mpi3mr/mpi3mr_transport.c:10: /kisskb/src/drivers/scsi/mpi3mr/mpi3mr_transport.c: In function 'mpi3mr_sas_port_add': /kisskb/src/include/linux/kern_levels.h:5:25: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'unsigned int' [-Werror=format=] 5 | #define KERN_SOH "\001" /* ASCII Start Of Header */ | ^~~~~~ /kisskb/src/include/linux/printk.h:436:25: note: in definition of macro 'printk_index_wrap' 436 | _p_func(_fmt, ##__VA_ARGS__); \ | ^~~~ /kisskb/src/include/linux/printk.h:517:9: note: in expansion of macro 'printk' 517 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~ /kisskb/src/include/linux/kern_levels.h:12:25: note: in expansion of macro 'KERN_SOH' 12 | #define KERN_WARNING KERN_SOH "4" /* warning conditions */ | ^~~~~~~~ /kisskb/src/include/linux/printk.h:517:16: note: in expansion of macro 'KERN_WARNING' 517 | printk(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~~ /kisskb/src/drivers/scsi/mpi3mr/mpi3mr_debug.h:46:9: note: in expansion of macro 'pr_warn' 46 | pr_warn("%s: " fmt, (ioc)->name, ##__VA_ARGS__) | ^~~~~~~ /kisskb/src/drivers/scsi/mpi3mr/mpi3mr_transport.c:1367:25: note: in expansion of macro 'ioc_warn' 1367 | ioc_warn(mrioc, "skipping port %u, max allowed value is %lu\n", | ^~~~~~~~ cc1: all warnings being treated as errors make[6]: *** [/kisskb/src/scripts/Makefile.build:244: drivers/scsi/mpi3mr/mpi3mr_transport.o] Error 1 make[5]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/scsi/mpi3mr] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/scsi] Error 2 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:485: drivers] Error 2 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/Makefile:1934: .] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 160 ARCH=sparc O=/kisskb/build/linus_allmodconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_sparc64-gcc13 # Build took: 0:09:57.942800