# git rev-parse -q --verify 4a4be1ad3a6efea16c56615f31117590fd881358^{commit} 4a4be1ad3a6efea16c56615f31117590fd881358 already have revision, skipping fetch # git checkout -q -f -B kisskb 4a4be1ad3a6efea16c56615f31117590fd881358 # git clean -qxdf # < git log -1 # commit 4a4be1ad3a6efea16c56615f31117590fd881358 # Author: Linus Torvalds # Date: Wed May 29 09:39:34 2024 -0700 # # Revert "vfs: Delete the associated dentry when deleting a file" # # This reverts commit 681ce8623567ba7e7333908e9826b77145312dda. # # We gave it a try, but it turns out the kernel test robot did in fact # find performance regressions for it, so we'll have to look at the more # involved alternative fixes for Yafang Shao's Elasticsearch load issue. # # There were several alternatives discussed, they just weren't as simple # as this first attempt. # # The report is of a -7.4% regression of filebench.sum_operations/s, which # appears significant enough to trigger my "this patch may get reverted if # somebody finds a performance regression on some other load" rule. # # So it's still the case that we should end up deleting dentries more # aggressively - or just be better at pruning them later - but it needs a # bit more finesse than this simple thing. # # Link: https://lore.kernel.org/all/202405291318.4dfbb352-oliver.sang@intel.com/ # Cc: Yafang Shao # Cc: Al Viro # Cc: Christian Brauner # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version # < git log --format=%s --max-count=1 4a4be1ad3a6efea16c56615f31117590fd881358 # make -s -j 40 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- allmodconfig # < make -s -j 40 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- help # make -s -j 40 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- olddefconfig # make -s -j 40 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] cc1: warning: unrecognized command line option '-Wno-shift-negative-value' cc1: warning: unrecognized command line option '-Wno-stringop-overflow' /kisskb/src/arch/sparc/power/hibernate.c:22:5: error: no previous prototype for 'pfn_is_nosave' [-Werror=missing-prototypes] int pfn_is_nosave(unsigned long pfn) ^ /kisskb/src/arch/sparc/power/hibernate.c:30:6: error: no previous prototype for 'save_processor_state' [-Werror=missing-prototypes] void save_processor_state(void) ^ /kisskb/src/arch/sparc/power/hibernate.c:35:6: error: no previous prototype for 'restore_processor_state' [-Werror=missing-prototypes] void restore_processor_state(void) ^ cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror] cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:244: arch/sparc/power/hibernate.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:485: arch/sparc/power] Error 2 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/arch/sparc/vdso/vclock_gettime.c:254:1: error: no previous prototype for '__vdso_clock_gettime' [-Werror=missing-prototypes] __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts) ^ /kisskb/src/arch/sparc/vdso/vclock_gettime.c:282:1: error: no previous prototype for '__vdso_clock_gettime_stick' [-Werror=missing-prototypes] __vdso_clock_gettime_stick(clockid_t clock, struct __kernel_old_timespec *ts) ^ /kisskb/src/arch/sparc/vdso/vclock_gettime.c:307:1: error: no previous prototype for '__vdso_gettimeofday' [-Werror=missing-prototypes] __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz) ^ /kisskb/src/arch/sparc/vdso/vclock_gettime.c:343:1: error: no previous prototype for '__vdso_gettimeofday_stick' [-Werror=missing-prototypes] __vdso_gettimeofday_stick(struct __kernel_old_timeval *tv, struct timezone *tz) ^ cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror] cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:244: arch/sparc/vdso/vclock_gettime.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:485: arch/sparc/vdso] Error 2 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/arch/sparc/prom/p1275.c:52:6: error: no previous prototype for 'prom_cif_init' [-Werror=missing-prototypes] void prom_cif_init(void *cif_handler, void *cif_stack) ^ cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror] cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:244: arch/sparc/prom/p1275.o] Error 1 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/arch/sparc/prom/misc_64.c:165:5: error: no previous prototype for 'prom_get_mmu_ihandle' [-Werror=missing-prototypes] int prom_get_mmu_ihandle(void) ^ cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror] cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:244: arch/sparc/prom/misc_64.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:485: arch/sparc/prom] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:485: arch/sparc] Error 2 In file included from /kisskb/src/arch/sparc/include/asm/floppy.h:5:0, from /kisskb/src/drivers/block/floppy.c:250: /kisskb/src/arch/sparc/include/asm/floppy_64.h:200:13: error: no previous prototype for 'sparc_floppy_irq' [-Werror=missing-prototypes] irqreturn_t sparc_floppy_irq(int irq, void *dev_cookie) ^ In file included from /kisskb/src/arch/sparc/include/asm/floppy.h:5:0, from /kisskb/src/drivers/block/floppy.c:250: /kisskb/src/arch/sparc/include/asm/floppy_64.h:437:6: error: no previous prototype for 'sun_pci_fd_dma_callback' [-Werror=missing-prototypes] void sun_pci_fd_dma_callback(struct ebus_dma_info *p, int event, void *cookie) ^ cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror] cc1: all warnings being treated as errors make[5]: *** [/kisskb/src/scripts/Makefile.build:244: drivers/block/floppy.o] Error 1 make[4]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/block] Error 2 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:16:9: error: unknown option after '#pragma GCC diagnostic' kind [-Werror=pragmas] #pragma GCC diagnostic ignored "-Wunused-const-variable" ^ In file included from /kisskb/src/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:18:0: /kisskb/src/drivers/gpu/drm/msm/adreno/adreno_gen7_0_0_snapshot.h:924:19: error: 'gen7_0_0_external_core_regs' defined but not used [-Werror=unused-variable] static const u32 *gen7_0_0_external_core_regs[] = { ^ In file included from /kisskb/src/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:19:0: /kisskb/src/drivers/gpu/drm/msm/adreno/adreno_gen7_2_0_snapshot.h:748:19: error: 'gen7_2_0_external_core_regs' defined but not used [-Werror=unused-variable] static const u32 *gen7_2_0_external_core_regs[] = { ^ In file included from /kisskb/src/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:20:0: /kisskb/src/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h:1188:43: error: 'gen7_9_0_sptp_clusters' defined but not used [-Werror=unused-variable] static struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] = { ^ /kisskb/src/drivers/gpu/drm/msm/adreno/adreno_gen7_9_0_snapshot.h:1438:19: error: 'gen7_9_0_external_core_regs' defined but not used [-Werror=unused-variable] static const u32 *gen7_9_0_external_core_regs[] = { ^ cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-shift-negative-value' [-Werror] cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror] cc1: all warnings being treated as errors make[7]: *** [/kisskb/src/scripts/Makefile.build:244: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.o] Error 1 make[7]: *** Waiting for unfinished jobs.... make[6]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/gpu/drm/msm] Error 2 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/gpu/drm] Error 2 make[4]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/gpu] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:485: drivers] Error 2 make[2]: *** [/kisskb/src/Makefile:1934: .] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 40 ARCH=sparc64 O=/kisskb/build/linus_allmodconfig_sparc64-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/sparc64-linux/bin/sparc64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_sparc64-gcc5 # Build took: 0:03:43.621839