# git rev-parse -q --verify 4a4be1ad3a6efea16c56615f31117590fd881358^{commit} 4a4be1ad3a6efea16c56615f31117590fd881358 already have revision, skipping fetch # git checkout -q -f -B kisskb 4a4be1ad3a6efea16c56615f31117590fd881358 # git clean -qxdf # < git log -1 # commit 4a4be1ad3a6efea16c56615f31117590fd881358 # Author: Linus Torvalds # Date: Wed May 29 09:39:34 2024 -0700 # # Revert "vfs: Delete the associated dentry when deleting a file" # # This reverts commit 681ce8623567ba7e7333908e9826b77145312dda. # # We gave it a try, but it turns out the kernel test robot did in fact # find performance regressions for it, so we'll have to look at the more # involved alternative fixes for Yafang Shao's Elasticsearch load issue. # # There were several alternatives discussed, they just weren't as simple # as this first attempt. # # The report is of a -7.4% regression of filebench.sum_operations/s, which # appears significant enough to trigger my "this patch may get reverted if # somebody finds a performance regression on some other load" rule. # # So it's still the case that we should end up deleting dentries more # aggressively - or just be better at pruning them later - but it needs a # bit more finesse than this simple thing. # # Link: https://lore.kernel.org/all/202405291318.4dfbb352-oliver.sang@intel.com/ # Cc: Yafang Shao # Cc: Al Viro # Cc: Christian Brauner # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 4a4be1ad3a6efea16c56615f31117590fd881358 # make -s -j 40 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- skiroot_defconfig # < make -s -j 40 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 40 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 40 ARCH=powerpc O=/kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/fs/btrfs/extent_io.c: In function 'extent_fiemap': /kisskb/src/fs/btrfs/extent_io.c:3285:19: warning: 'last_extent_end' may be used uninitialized in this function [-Wmaybe-uninitialized] if (cache.cached && cache.offset + cache.len >= last_extent_end) { ^ /kisskb/src/fs/btrfs/extent_io.c: At top level: cc1: warning: unrecognized command line option '-Wno-shift-negative-value' cc1: warning: unrecognized command line option '-Wno-shift-negative-value' cc1: warning: unrecognized command line option '-Wno-stringop-overflow' Completed OK # rm -rf /kisskb/build/linus_skiroot_defconfig_powerpc-gcc5 # Build took: 0:01:01.637276