# git rev-parse -q --verify 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c^{commit} 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c already have revision, skipping fetch # git checkout -q -f -B kisskb 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c # git clean -qxdf # < git log -1 # commit 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c # Author: Michael Ellerman # Date: Sat Jul 6 22:08:33 2024 +1000 # # selftests/powerpc: Fix build with USERCFLAGS set # # Currently building the powerpc selftests with USERCFLAGS set to anything # causes the build to break: # # $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error # ... # gcc -Wno-error cache_shape.c ... # cache_shape.c:18:10: fatal error: utils.h: No such file or directory # 18 | #include "utils.h" # | ^~~~~~~~~ # compilation terminated. # # This happens because the USERCFLAGS are added to CFLAGS in lib.mk, which # causes the check of CFLAGS in powerpc/flags.mk to skip setting CFLAGS at # all, resulting in none of the usual CFLAGS being passed. That can # be seen in the output above, the only flag passed to the compiler is # -Wno-error. # # Fix it by dropping the conditional setting of CFLAGS in flags.mk. # Instead always set CFLAGS, but also append USERCFLAGS if they are set. # # Note that appending to CFLAGS (with +=) wouldn't work, because flags.mk # is included by multiple Makefiles (to support partial builds), causing # CFLAGS to be appended to multiple times. Additionally that would place # the USERCFLAGS prior to the standard CFLAGS, meaning the USERCFLAGS # couldn't override the standard flags. Being able to override the # standard flags is desirable, for example for adding -Wno-error. # # With the fix in place, the CFLAGS are set correctly, including the # USERCFLAGS: # # $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error # ... # gcc -std=gnu99 -O2 -Wall -Werror -DGIT_VERSION='"v6.10-rc2-7-gdea17e7e56c3"' # -I/home/michael/linux/tools/testing/selftests/powerpc/include -Wno-error # cache_shape.c ... # # Fixes: 5553a79387e9 ("selftests/powerpc: Add flags.mk to support pmu buildable") # Signed-off-by: Michael Ellerman # Link: https://msgid.link/20240706120833.909853-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_smp_defconfig Using /kisskb/src/arch/powerpc/configs/mpc85xx_base.config as base Merging /kisskb/src/arch/powerpc/configs/85xx-32bit.config Merging /kisskb/src/arch/powerpc/configs/85xx-smp.config Merging /kisskb/src/arch/powerpc/configs/85xx-hw.config Merging /kisskb/src/arch/powerpc/configs/fsl-emb-nonhw.config # # merged configuration written to .config (needs make) # # < make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/include/linux/build_bug.h:5:0, from /kisskb/src/include/linux/container_of.h:5, from /kisskb/src/include/linux/list.h:5, from /kisskb/src/include/linux/module.h:12, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:28:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:77:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:138:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: At top level: cc1: warning: unrecognized command line option '-Wno-shift-negative-value' cc1: warning: unrecognized command line option '-Wno-stringop-overflow' Segmentation fault (core dumped) make[3]: *** [/kisskb/src/scripts/Makefile.vmlinux:34: vmlinux] Error 139 make[2]: *** [/kisskb/src/Makefile:1171: vmlinux] Error 2 make[1]: *** [/kisskb/src/Makefile:240: __sub-make] Error 2 make: *** [Makefile:240: __sub-make] Error 2 Command 'make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/powerpc-fixes_mpc85xx_smp_defconfig_powerpc-gcc5 # Build took: 0:01:06.576867