Buildresult: powerpc-fixes/ppc64_defconfig+NO_HUGETLB+4K_PAGES/powerpc-gcc13 built on Jul 10, 06:40

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Jul 10, 06:40
Duration:	0:02:01.147104
Builder:	alpine1
Revision:	selftests/powerpc: Fix build with USERCFLAGS set (`8b7f59de92ac65aa21c7d779274dbfa577ae2d2c)`
Target:	powerpc-fixes/ppc64_defconfig+NO_HUGETLB+4K_PAGES/powerpc-gcc13
Branch:	powerpc-fixes
Compiler:	powerpc-gcc13 (powerpc64-linux-gcc (GCC) 13.1.0 / GNU ld (GNU Binutils) 2.40)
Config:	ppc64_defconfig+NO_HUGETLB+4K_PAGES (download)
Log:	Download original Possible warnings (1) .config:5052:warning: override: reassigning to symbol PPC_4K_PAGES Full Log # git rev-parse -q --verify 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c^{commit} 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c already have revision, skipping fetch # git checkout -q -f -B kisskb 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c # git clean -qxdf # < git log -1 # commit 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c # Author: Michael Ellerman <mpe@ellerman.id.au> # Date: Sat Jul 6 22:08:33 2024 +1000 # # selftests/powerpc: Fix build with USERCFLAGS set # # Currently building the powerpc selftests with USERCFLAGS set to anything # causes the build to break: # # $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error # ... # gcc -Wno-error cache_shape.c ... # cache_shape.c:18:10: fatal error: utils.h: No such file or directory # 18 \| #include "utils.h" # \| ^~~~~~~~~ # compilation terminated. # # This happens because the USERCFLAGS are added to CFLAGS in lib.mk, which # causes the check of CFLAGS in powerpc/flags.mk to skip setting CFLAGS at # all, resulting in none of the usual CFLAGS being passed. That can # be seen in the output above, the only flag passed to the compiler is # -Wno-error. # # Fix it by dropping the conditional setting of CFLAGS in flags.mk. # Instead always set CFLAGS, but also append USERCFLAGS if they are set. # # Note that appending to CFLAGS (with +=) wouldn't work, because flags.mk # is included by multiple Makefiles (to support partial builds), causing # CFLAGS to be appended to multiple times. Additionally that would place # the USERCFLAGS prior to the standard CFLAGS, meaning the USERCFLAGS # couldn't override the standard flags. Being able to override the # standard flags is desirable, for example for adding -Wno-error. # # With the fix in place, the CFLAGS are set correctly, including the # USERCFLAGS: # # $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error # ... # gcc -std=gnu99 -O2 -Wall -Werror -DGIT_VERSION='"v6.10-rc2-7-gdea17e7e56c3"' # -I/home/michael/linux/tools/testing/selftests/powerpc/include -Wno-error # cache_shape.c ... # # Fixes: 5553a79387e9 ("selftests/powerpc: Add flags.mk to support pmu buildable") # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # Link: https://msgid.link/20240706120833.909853-1-mpe@ellerman.id.au # < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ppc64_defconfig+NO_HUGETLB+4K_PAGES_powerpc-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc64_defconfig # Added to kconfig CONFIG_PPC_64K_PAGES=n # Added to kconfig CONFIG_PPC_4K_PAGES=y # Added to kconfig CONFIG_HUGETLBFS=n # < make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ppc64_defconfig+NO_HUGETLB+4K_PAGES_powerpc-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- help # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ppc64_defconfig+NO_HUGETLB+4K_PAGES_powerpc-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig .config:5052:warning: override: reassigning to symbol PPC_4K_PAGES # make -s -j 160 ARCH=powerpc O=/kisskb/build/powerpc-fixes_ppc64_defconfig+NO_HUGETLB+4K_PAGES_powerpc-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- Completed OK # rm -rf /kisskb/build/powerpc-fixes_ppc64_defconfig+NO_HUGETLB+4K_PAGES_powerpc-gcc13 # Build took: 0:02:01.147104

© Michael Ellerman 2006-2018.