# git rev-parse -q --verify 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c^{commit}
8b7f59de92ac65aa21c7d779274dbfa577ae2d2c
already have revision, skipping fetch
# git checkout -q -f -B kisskb 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c
# git clean -qxdf
# < git log -1
# commit 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c
# Author: Michael Ellerman <mpe@ellerman.id.au>
# Date:   Sat Jul 6 22:08:33 2024 +1000
# 
#     selftests/powerpc: Fix build with USERCFLAGS set
#     
#     Currently building the powerpc selftests with USERCFLAGS set to anything
#     causes the build to break:
#     
#       $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error
#       ...
#       gcc -Wno-error    cache_shape.c ...
#       cache_shape.c:18:10: fatal error: utils.h: No such file or directory
#          18 | #include "utils.h"
#             |          ^~~~~~~~~
#       compilation terminated.
#     
#     This happens because the USERCFLAGS are added to CFLAGS in lib.mk, which
#     causes the check of CFLAGS in powerpc/flags.mk to skip setting CFLAGS at
#     all, resulting in none of the usual CFLAGS being passed. That can
#     be seen in the output above, the only flag passed to the compiler is
#     -Wno-error.
#     
#     Fix it by dropping the conditional setting of CFLAGS in flags.mk.
#     Instead always set CFLAGS, but also append USERCFLAGS if they are set.
#     
#     Note that appending to CFLAGS (with +=) wouldn't work, because flags.mk
#     is included by multiple Makefiles (to support partial builds), causing
#     CFLAGS to be appended to multiple times. Additionally that would place
#     the USERCFLAGS prior to the standard CFLAGS, meaning the USERCFLAGS
#     couldn't override the standard flags. Being able to override the
#     standard flags is desirable, for example for adding -Wno-error.
#     
#     With the fix in place, the CFLAGS are set correctly, including the
#     USERCFLAGS:
#     
#       $ make -C tools/testing/selftests/powerpc V=1 USERCFLAGS=-Wno-error
#       ...
#       gcc -std=gnu99 -O2 -Wall -Werror -DGIT_VERSION='"v6.10-rc2-7-gdea17e7e56c3"'
#       -I/home/michael/linux/tools/testing/selftests/powerpc/include -Wno-error
#       cache_shape.c ...
#     
#     Fixes: 5553a79387e9 ("selftests/powerpc: Add flags.mk to support pmu buildable")
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
#     Link: https://msgid.link/20240706120833.909853-1-mpe@ellerman.id.au
# < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version
# < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-ld --version
# < git log --format=%s --max-count=1 8b7f59de92ac65aa21c7d779274dbfa577ae2d2c
# make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-fixes_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-  defconfig
Using /kisskb/src/arch/mips/configs/generic_defconfig as base
Merging /kisskb/src/arch/mips/configs/generic/32r2.config
Merging /kisskb/src/arch/mips/configs/generic/el.config
Merging /kisskb/src/arch/mips/configs/generic/board-boston.config
Merging /kisskb/src/arch/mips/configs/generic/board-marduk.config
Merging /kisskb/src/arch/mips/configs/generic/board-ni169445.config
Merging /kisskb/src/arch/mips/configs/generic/board-ocelot.config
Merging /kisskb/src/arch/mips/configs/generic/board-ranchu.config
Merging /kisskb/src/arch/mips/configs/generic/board-sead-3.config
Merging /kisskb/src/arch/mips/configs/generic/board-virt.config
Merging /kisskb/src/arch/mips/configs/generic/board-xilfpga.config
# < make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-fixes_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-  help
# make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-fixes_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-  olddefconfig
# make -s -j 40 ARCH=mips O=/kisskb/build/powerpc-fixes_defconfig_mipsel-gcc5 CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-  
/kisskb/src/arch/mips/boot/dts/img/boston.dts:128.17-178.5: Warning (interrupt_provider): /pci@14000000/pci2_root@0,0: '#interrupt-cells' found, but node is not an interrupt provider
/kisskb/src/arch/mips/boot/dts/img/boston.dts:136.23-177.6: Warning (interrupt_provider): /pci@14000000/pci2_root@0,0/eg20t_bridge@1,0,0: '#interrupt-cells' found, but node is not an interrupt provider
arch/mips/boot/dts/img/boston.dtb: Warning (interrupt_map): Failed prerequisite 'interrupt_provider'
Completed OK
# rm -rf /kisskb/build/powerpc-fixes_defconfig_mipsel-gcc5
# Build took: 0:00:59.817804