# git rev-parse -q --verify 0afaf52eff136daf4edc2aac3dc9793fa247ed0c^{commit}
0afaf52eff136daf4edc2aac3dc9793fa247ed0c
already have revision, skipping fetch
# git checkout -q -f -B kisskb 0afaf52eff136daf4edc2aac3dc9793fa247ed0c
# git clean -qxdf
# < git log -1
# commit 0afaf52eff136daf4edc2aac3dc9793fa247ed0c
# Author: HONG Yifan <elsk@google.com>
# Date:   Wed Jul 17 01:50:41 2024 +0000
# 
#     kconfig: recursive checks drop file/lineno
#     
#     This prevents segfault when getting filename and lineno in recursive
#     checks.
#     
#     If the following snippet is found in Kconfig:
#     
#     [Test code 1]
#     
#     config FOO
#             bool
#             depends on BAR
#             select BAR
#     
#     ... without BAR defined; then there is a segfault.
#     
#       Kconfig:34:error: recursive dependency detected!
#       Kconfig:34:   symbol FOO depends on BAR
#       make[4]: *** [scripts/kconfig/Makefile:85: allnoconfig] Segmentation fault
#     
#     This is because of the following. BAR is a fake entry created by
#     sym_lookup() with prop being NULL. In the recursive check, there is a
#     NULL check for prop to fall back to stack->sym->prop if stack->prop is
#     NULL. However, in this case, stack->sym points to the fake BAR entry
#     created by sym_lookup(), so prop is still NULL. prop was then referenced
#     without additional NULL checks, causing segfault.
#     
#     As the previous email thread suggests, the file and lineno for select is
#     also wrong:
#     
#     [Test code 2]
#     
#     config FOO
#            bool
#     
#     config BAR
#            bool
#     
#     config FOO
#            bool "FOO"
#            depends on BAR
#            select BAR
#     
#       $ make defconfig
#       *** Default configuration is based on 'x86_64_defconfig'
#       Kconfig:1:error: recursive dependency detected!
#       Kconfig:1: symbol FOO depends on BAR
#       Kconfig:4: symbol BAR is selected by FOO
#       [...]
#     
#     Kconfig:4 should be Kconfig:10.
#     
#     This patch deletes the wrong and segfault-prone filename/lineno
#     inference completely. With this patch, Test code 1 yields:
#     
#     error: recursive dependency detected!
#             symbol FOO depends on BAR
#             symbol BAR is selected by FOO
#     
#     Signed-off-by: HONG Yifan <elsk@google.com>
#     Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
# < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-gcc --version
# < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld --version
# < git log --format=%s --max-count=1 0afaf52eff136daf4edc2aac3dc9793fa247ed0c
# make -s -j 160 ARCH=sparc64 O=/kisskb/build/kbuild_defconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  defconfig
# < make -s -j 160 ARCH=sparc64 O=/kisskb/build/kbuild_defconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  help
# make -s -j 160 ARCH=sparc64 O=/kisskb/build/kbuild_defconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  olddefconfig
# make -s -j 160 ARCH=sparc64 O=/kisskb/build/kbuild_defconfig_sparc64-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-  
<stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
/kisskb/src/arch/sparc/prom/p1275.c:52:6: warning: no previous prototype for 'prom_cif_init' [-Wmissing-prototypes]
   52 | void prom_cif_init(void *cif_handler, void *cif_stack)
      |      ^~~~~~~~~~~~~
/kisskb/src/arch/sparc/prom/misc_64.c:165:5: warning: no previous prototype for 'prom_get_mmu_ihandle' [-Wmissing-prototypes]
  165 | int prom_get_mmu_ihandle(void)
      |     ^~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:254:1: warning: no previous prototype for '__vdso_clock_gettime' [-Wmissing-prototypes]
  254 | __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
      | ^~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:282:1: warning: no previous prototype for '__vdso_clock_gettime_stick' [-Wmissing-prototypes]
  282 | __vdso_clock_gettime_stick(clockid_t clock, struct __kernel_old_timespec *ts)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:307:1: warning: no previous prototype for '__vdso_gettimeofday' [-Wmissing-prototypes]
  307 | __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
      | ^~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vclock_gettime.c:343:1: warning: no previous prototype for '__vdso_gettimeofday_stick' [-Wmissing-prototypes]
  343 | __vdso_gettimeofday_stick(struct __kernel_old_timeval *tv, struct timezone *tz)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /kisskb/src/arch/sparc/vdso/vdso32/vclock_gettime.c:22:
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:254:1: warning: no previous prototype for '__vdso_clock_gettime' [-Wmissing-prototypes]
  254 | __vdso_clock_gettime(clockid_t clock, struct __kernel_old_timespec *ts)
      | ^~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:282:1: warning: no previous prototype for '__vdso_clock_gettime_stick' [-Wmissing-prototypes]
  282 | __vdso_clock_gettime_stick(clockid_t clock, struct __kernel_old_timespec *ts)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:307:1: warning: no previous prototype for '__vdso_gettimeofday' [-Wmissing-prototypes]
  307 | __vdso_gettimeofday(struct __kernel_old_timeval *tv, struct timezone *tz)
      | ^~~~~~~~~~~~~~~~~~~
/kisskb/src/arch/sparc/vdso/vdso32/../vclock_gettime.c:343:1: warning: no previous prototype for '__vdso_gettimeofday_stick' [-Wmissing-prototypes]
  343 | __vdso_gettimeofday_stick(struct __kernel_old_timeval *tv, struct timezone *tz)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~
/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld: warning: arch/sparc/vdso/vdso-note.o: missing .note.GNU-stack section implies executable stack
/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld: warning: arch/sparc/vdso/vdso32/vdso-note.o: missing .note.GNU-stack section implies executable stack
/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sparc64-linux/bin/sparc64-linux-ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
WARNING: modpost: EXPORT symbol "_mcount" [vmlinux] version generation failed, symbol will not be versioned.
Is "_mcount" prototyped in <asm/asm-prototypes.h>?
Completed OK
# rm -rf /kisskb/build/kbuild_defconfig_sparc64-gcc13
# Build took: 0:01:20.936825