# git rev-parse -q --verify dc1c8034e31b14a2e5e212104ec508aec44ce1b9^{commit} dc1c8034e31b14a2e5e212104ec508aec44ce1b9 already have revision, skipping fetch # git checkout -q -f -B kisskb dc1c8034e31b14a2e5e212104ec508aec44ce1b9 # git clean -qxdf # < git log -1 # commit dc1c8034e31b14a2e5e212104ec508aec44ce1b9 # Author: Linus Torvalds # Date: Sun Jul 28 20:24:12 2024 -0700 # # minmax: simplify min()/max()/clamp() implementation # # Now that we no longer have any C constant expression contexts (ie array # size declarations or static initializers) that use min() or max(), we # can simpify the implementation by not having to worry about the result # staying as a C constant expression. # # So now we can unconditionally just use temporary variables of the right # type, and get rid of the excessive expansion that used to come from the # use of # # __builtin_choose_expr(__is_constexpr(...), .. # # to pick the specialized code for constant expressions. # # Another expansion simplification is to pass the temporary variables (in # addition to the original expression) to our __types_ok() macro. That # may superficially look like it complicates the macro, but when we only # want the type of the expression, expanding the temporary variable names # is much simpler and smaller than expanding the potentially complicated # original expression. # # As a result, on my machine, doing a # # $ time make drivers/staging/media/atomisp/pci/isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.i # # goes from # # real 0m16.621s # user 0m15.360s # sys 0m1.221s # # to # # real 0m2.532s # user 0m2.091s # sys 0m0.452s # # because the token expansion goes down dramatically. # # In particular, the longest line expansion (which was line 71 of that # 'ia_css_ynr.host.c' file) shrinks from 23,338kB (yes, 23MB for one # single line) to "just" 1,444kB (now "only" 1.4MB). # # And yes, that line is still the line from hell, because it's doing # multiple levels of "min()/max()" expansion thanks to some of them being # hidden inside the uDIGIT_FITTING() macro. # # Lorenzo has a nice cleanup patch that makes that driver use inline # functions instead of macros for sDIGIT_FITTING() and uDIGIT_FITTING(), # which will fix that line once and for all, but the 16-fold reduction in # this case does show why we need to simplify these helpers. # # Cc: David Laight # Cc: Lorenzo Stoakes # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux-ld --version # < git log --format=%s --max-count=1 dc1c8034e31b14a2e5e212104ec508aec44ce1b9 # make -s -j 160 ARCH=sh O=/kisskb/build/linus_allmodconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # < make -s -j 160 ARCH=sh O=/kisskb/build/linus_allmodconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux- help # make -s -j 160 ARCH=sh O=/kisskb/build/linus_allmodconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux- olddefconfig # make -s -j 160 ARCH=sh O=/kisskb/build/linus_allmodconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1519:2: warning: #warning syscall clone3 not implemented [-Wcpp] /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S: Assembler messages: /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:85: Warning: overflow in branch to __restore_all; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:357: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:360: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/kernel/fork.c: In function '__do_sys_clone3': /kisskb/src/kernel/fork.c:3072:2: error: #warning clone3() entry point is missing, please fix [-Werror=cpp] 3072 | #warning clone3() entry point is missing, please fix | ^~~~~~~ cc1: all warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:244: kernel/fork.o] Error 1 make[4]: *** Waiting for unfinished jobs.... {standard input}: Assembler messages: {standard input}: Warning: end of file not at end of a line; newline inserted {standard input}:1111: Error: unknown pseudo-op: `.l18' {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive {standard input}:1070: Error: displacement to undefined symbol .L142 overflows 8-bit field {standard input}:1075: Error: displacement to undefined symbol .L161 overflows 8-bit field {standard input}:1059: Error: pcrel too far {standard input}:1060: Error: pcrel too far {standard input}:1061: Error: pcrel too far sh4-linux-gcc: internal compiler error: Segmentation fault signal terminated program cc1 Please submit a full bug report, with preprocessed source (by using -freport-bug). See for instructions. make[6]: *** [/kisskb/src/scripts/Makefile.build:244: drivers/net/pcs/pcs-xpcs.o] Error 4 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/net/pcs] Error 2 make[5]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:485: kernel] Error 2 make[3]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/net] Error 2 make[4]: *** Waiting for unfinished jobs.... {standard input}: Assembler messages: {standard input}: Warning: end of file not at end of a line; newline inserted {standard input}:1270: Error: unknown pseudo-op: `.al' {standard input}: Error: open CFI at the end of file; missing .cfi_endproc directive {standard input}:1254: Error: pcrel too far {standard input}:1255: Error: pcrel too far sh4-linux-gcc: internal compiler error: Segmentation fault signal terminated program cc1 Please submit a full bug report, with preprocessed source (by using -freport-bug). See for instructions. make[6]: *** [/kisskb/src/scripts/Makefile.build:244: drivers/hwmon/pmbus/mp2975.o] Error 4 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/hwmon/pmbus] Error 2 make[5]: *** Waiting for unfinished jobs.... make[4]: *** [/kisskb/src/scripts/Makefile.build:485: drivers/hwmon] Error 2 make[3]: *** [/kisskb/src/scripts/Makefile.build:485: drivers] Error 2 make[2]: *** [/kisskb/src/Makefile:1925: .] Error 2 make[1]: *** [/kisskb/src/Makefile:224: __sub-make] Error 2 make: *** [Makefile:224: __sub-make] Error 2 Command 'make -s -j 160 ARCH=sh O=/kisskb/build/linus_allmodconfig_sh4-gcc13 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-13.1.0-nolibc/sh4-linux/bin/sh4-linux- ' returned non-zero exit status 2. # rm -rf /kisskb/build/linus_allmodconfig_sh4-gcc13 # Build took: 0:05:26.026996