Buildresult: linus/m5272c3_defconfig/m68k-gcc8 built on Aug 1, 05:00

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Aug 1, 05:00
Duration:	0:00:18.785137
Builder:	ka4
Revision:	minmax: fix up min3() and max3() too (`21b136cc63d2a9ddd60d4699552b69c214b32964)`
Target:	linus/m5272c3_defconfig/m68k-gcc8
Branch:	linus
Compiler:	m68k-gcc8 (m68k-linux-gcc (GCC) 8.5.0 / GNU ld (GNU Binutils) 2.36.1)
Config:	m5272c3_defconfig (download)
Log:	Download original No warnings found in log. Full Log # git rev-parse -q --verify 21b136cc63d2a9ddd60d4699552b69c214b32964^{commit} 21b136cc63d2a9ddd60d4699552b69c214b32964 already have revision, skipping fetch # git checkout -q -f -B kisskb 21b136cc63d2a9ddd60d4699552b69c214b32964 # git clean -qxdf # < git log -1 # commit 21b136cc63d2a9ddd60d4699552b69c214b32964 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Tue Jul 30 15:44:16 2024 -0700 # # minmax: fix up min3() and max3() too # # David Laight pointed out that we should deal with the min3() and max3() # mess too, which still does excessive expansion. # # And our current macros are actually rather broken. # # In particular, the macros did this: # # #define min3(x, y, z) min((typeof(x))min(x, y), z) # #define max3(x, y, z) max((typeof(x))max(x, y), z) # # and that not only is a nested expansion of possibly very complex # arguments with all that involves, the typing with that "typeof()" cast # is completely wrong. # # For example, imagine what happens in max3() if 'x' happens to be a # 'unsigned char', but 'y' and 'z' are 'unsigned long'. The types are # compatible, and there's no warning - but the result is just random # garbage. # # No, I don't think we've ever hit that issue in practice, but since we # now have sane infrastructure for doing this right, let's just use it. # It fixes any excessive expansion, and also avoids these kinds of broken # type issues. # # Requested-by: David Laight <David.Laight@aculab.com> # Acked-by: Arnd Bergmann <arnd@kernel.org> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 21b136cc63d2a9ddd60d4699552b69c214b32964 # make -s -j 40 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- m5272c3_defconfig # < make -s -j 40 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- help # make -s -j 40 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- olddefconfig # make -s -j 40 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.5.0-nolibc/m68k-linux/bin/m68k-linux- Completed OK # rm -rf /kisskb/build/linus_m5272c3_defconfig_m68k-gcc8 # Build took: 0:00:18.785137

© Michael Ellerman 2006-2018.