# git rev-parse -q --verify dd41b283ef2f028e414312706b48f2880b7050b5^{commit} # git fetch -q -n -f git://fs.ozlabs.ibm.com/kernel/crypto master # git rev-parse -q --verify dd41b283ef2f028e414312706b48f2880b7050b5^{commit} dd41b283ef2f028e414312706b48f2880b7050b5 # git checkout -q -f -B kisskb dd41b283ef2f028e414312706b48f2880b7050b5 # git clean -qxdf # < git log -1 # commit dd41b283ef2f028e414312706b48f2880b7050b5 # Author: Eric Biggers # Date: Sun Oct 20 11:02:58 2024 -0700 # # crypto: mips/crc32 - fix the CRC32C implementation # # Commit ca459e5f826f ("crypto: mips/crc32 - Clean up useless assignment # operations") changed crc32c_mips_le_hw() to use the instructions that # use the "regular" CRC32 polynomial instead of the Castagnoli polynomial. # Therefore it can't be computing CRC32C values correctly anymore. # # I haven't been successful in running a MIPS kernel in QEMU, but based on # code review this is the fix that is needed. # # Fixes: ca459e5f826f ("crypto: mips/crc32 - Clean up useless assignment operations") # Cc: Guan Wentao # Cc: WangYuli # Signed-off-by: Eric Biggers # Acked-by: Wentao Guan # Acked-by: WangYuli # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 dd41b283ef2f028e414312706b48f2880b7050b5 # make -s -j 32 ARCH=x86_64 O=/kisskb/build/crypto_allnoconfig_x86_64-gcc8.1 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # < make -s -j 32 ARCH=x86_64 O=/kisskb/build/crypto_allnoconfig_x86_64-gcc8.1 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- help # make -s -j 32 ARCH=x86_64 O=/kisskb/build/crypto_allnoconfig_x86_64-gcc8.1 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 32 ARCH=x86_64 O=/kisskb/build/crypto_allnoconfig_x86_64-gcc8.1 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- Completed OK # rm -rf /kisskb/build/crypto_allnoconfig_x86_64-gcc8.1 # Build took: 0:00:33.502763